Replace FragmentRendererPass with tagged locator (see #3676)

aschempp · web-flow · commit 591e888c5ed9 · 2021-11-16T11:12:53.000+01:00
Description ----------- The `FragmentRendererPass` arguments have become deprecated in symfony/symfony#40468. Luckily, we don't actually need to use the compiler pass to get a list of services 😅 Commits ------- e10c5339 Replace FragmentRendererPass with tagged locator ff626d63 CS d270e6e7 CS
diff --git a/src/ContaoCoreBundle.php b/src/ContaoCoreBundle.php
@@ -49,7 +49,6 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\EventDispatcher\DependencyInjection\AddEventAliasesPass;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
-use Symfony\Component\HttpKernel\DependencyInjection\FragmentRendererPass;
 
 class ContaoCoreBundle extends Bundle
 {
@@ -107,7 +106,6 @@ public function build(ContainerBuilder $container): void
             )
         );
 
-        $container->addCompilerPass(new FragmentRendererPass('contao.fragment.handler'));
         $container->addCompilerPass(new RemembermeServicesPass('contao_frontend'));
         $container->addCompilerPass(new DataContainerCallbackPass());
         $container->addCompilerPass(new TranslationDataCollectorPass());
diff --git a/src/Resources/config/services.yml b/src/Resources/config/services.yml
@@ -297,7 +297,7 @@ services:
         class: Contao\CoreBundle\Fragment\FragmentHandler
         decorates: fragment.handler
         arguments:
-            - ~ # fragment renderer locator
+            - [!tagged_locator { tag: kernel.fragment_renderer, index_by: alias }]
             - '@contao.fragment.handler.inner'
             - '@request_stack'
             - '@contao.fragment.registry'
diff --git a/tests/ContaoCoreBundleTest.php b/tests/ContaoCoreBundleTest.php
@@ -46,7 +46,6 @@
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\EventDispatcher\DependencyInjection\AddEventAliasesPass;
-use Symfony\Component\HttpKernel\DependencyInjection\FragmentRendererPass;
 
 class ContaoCoreBundleTest extends TestCase
 {
@@ -64,7 +63,6 @@ public function testAddsTheCompilerPasses(): void
             RegisterPagesPass::class,
             RegisterFragmentsPass::class,
             RegisterFragmentsPass::class,
-            FragmentRendererPass::class,
             RemembermeServicesPass::class,
             DataContainerCallbackPass::class,
             TranslationDataCollectorPass::class,

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,6 @@`
`49`	`49`	`use Symfony\Component\DependencyInjection\ContainerBuilder;`
`50`	`50`	`use Symfony\Component\EventDispatcher\DependencyInjection\AddEventAliasesPass;`
`51`	`51`	`use Symfony\Component\HttpKernel\Bundle\Bundle;`
`52`		`-use Symfony\Component\HttpKernel\DependencyInjection\FragmentRendererPass;`
`53`	`52`
`54`	`53`	`class ContaoCoreBundle extends Bundle`
`55`	`54`	`{`
`@@ -107,7 +106,6 @@ public function build(ContainerBuilder $container): void`
`107`	`106`	`)`
`108`	`107`	`);`
`109`	`108`
`110`		`- $container->addCompilerPass(new FragmentRendererPass('contao.fragment.handler'));`
`111`	`109`	`$container->addCompilerPass(new RemembermeServicesPass('contao_frontend'));`
`112`	`110`	`$container->addCompilerPass(new DataContainerCallbackPass());`
`113`	`111`	`$container->addCompilerPass(new TranslationDataCollectorPass());`