[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas: see if we can change the zoom step from 2x to 1.5x #5906

Open
maltenuhn opened this issue Jun 12, 2024 · 2 comments
Open

Canvas: see if we can change the zoom step from 2x to 1.5x #5906

maltenuhn opened this issue Jun 12, 2024 · 2 comments
Labels
Canvas Affects the visual editor
Milestone

Comments

@maltenuhn
Copy link
Member

Problem
With page building, the default 50% zoom is often too zoomed out, but 1x is too much. When we built it, we had concerns that 75% zoom might create canvas selection problems or selection rendering problems - but we never tested this.

Solution
Change the multiplier to 1.5. Test if fine-grained selection works (click v close next to an element and check it doesn't get selected), and the outlines are drawn correctly with no weird artefacts.

Send a test link on Discord and please ping you can use the graphics QA department @lankaukk secretly runs.

  • Iff it looks good and behaves well, we can merge it
  • If it does not, try 80% zoom instead (this might require hard-coding the interval) and share a test link with Graphics QA - don't refactor the code yet if it's not an array, because we might throw it away if it's not good!). If that looks good, we can merge it.
  • Otherwise, leave a comment for our future selves in the zoom step and explain why we zoom in intervals of 2, and close the ticket.
@maltenuhn maltenuhn added the Canvas Affects the visual editor label Jun 13, 2024
@maltenuhn maltenuhn added this to the 1. Creation milestone Jun 13, 2024
@bkrmendy bkrmendy self-assigned this Jun 13, 2024
@bkrmendy
Copy link
Contributor

Last attempt: #5932

problems:

Image

Image

Image

  • those values flucutate +/-1 pixel (or so), so maybe that's the rendering artifact
  • zooming out leads to the weird non-rounded numbers in the inspector and on the labels, but zooming in makes the numbers jump around a little too (but the end result isn't as drastic)

@bkrmendy bkrmendy removed their assignment Jun 13, 2024
@maltenuhn
Copy link
Member Author

I'm gonna move this back to the backlog (since there were non-trivial issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Canvas Affects the visual editor
Projects
None yet
Development

No branches or pull requests

2 participants