Improve sorting of vendor results for available packages

Seldaek · Seldaek · commit eda1d89b1b95 · 2022-05-13T09:23:43.000+02:00
diff --git a/src/Composer/Command/CompletionTrait.php b/src/Composer/Command/CompletionTrait.php
@@ -132,7 +132,22 @@ private function suggestAvailablePackage(int $max = 99): \Closure
                 $results = array_map(function (string $name): string {
                     return $name.'/';
                 }, $results);
-                return array_slice($results, 0, 1000);
+
+                // sort shorter results first to avoid auto-expanding the completion to a longer string than needed
+                usort($results, function (string $a, string $b) {
+                    return \strlen($a) - \strlen($b);
+                });
+
+                $pinned = [];
+
+                // ensure if the input is an exact match that it is always in the result set
+                $completionInput = $input->getCompletionValue().'/';
+                if (in_array($completionInput, $results, true)) {
+                    $pinned[] = $completionInput;
+                    array_splice($results, array_search($completionInput, $results, true), 1);
+                }
+
+                return array_merge($pinned, array_slice($results, 0, $max - \count($pinned)));
             }
 
             return array_slice($results, 0, $max);
