Support all possible paths for input parameters (basedir, workdir, upperdir)? #271
eriksjolund
started this conversation in
General
Replies: 1 comment 1 reply
-
|
On Tue, Apr 2, 2024, at 2:06 AM, Erik Sjölund wrote:
Supporting all possible paths, is it a goal worth aiming for?
If we can, but without deeply analyzing this I’d be fine to start by rejecting characters like \ that we think may be problematic. Let’s be realistic no one is going to use \ in their mount points outside of a fuzzer or something, and we should just not crash or create ill defined behavior.
|
Beta Was this translation helpful? Give feedback.
1 reply
-
|
I thought it would be easier for other software projects to integrate with composefs if they could use any path (i.e any possibilities of backslash, colon and comma). This is just my gut feeling. I'm not speaking out of experience here. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Supporting all possible paths, is it a goal worth aiming for?
When I was reading the code in the file libcomposefs/lcfs-mount.c, I noticed that
commas are escaped but not the escape character (backslash). Often such code
would also escape the escape character (i.e a backslash), something like this
Anyway, it seems to be a bit tricky to support all possible paths (i.e. the whole "value space" of possible paths for basedir, upperdir and workdir).
I'm bringing up this discussion topic because changes to the user interface are easier to make early in a software project. (I don't need this feature myself)
Beta Was this translation helpful? Give feedback.
All reactions