fix(changelog.py): cross-platform path handling using os.path.join and modify the path linter and test parameter

Yusin0903 · Lee-W · commit 99b4faae99ce · 2025-05-06T10:29:34.000+08:00
diff --git a/commitizen/commands/changelog.py b/commitizen/commands/changelog.py
@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import os
 import os.path
 from difflib import SequenceMatcher
 from operator import itemgetter
@@ -42,7 +43,7 @@ def __init__(self, config: BaseConfig, args):
                 f"or the setting `changelog_file` in {self.config.path}"
             )
         self.file_name = (
-            str(Path(self.config.path.parent) / changelog_file_name)
+            os.path.join(str(self.config.path.parent), changelog_file_name)
             if self.config.path is not None
             else changelog_file_name
         )
diff --git a/tests/test_changelog.py b/tests/test_changelog.py
@@ -1,3 +1,4 @@
+import os
 import re
 from dataclasses import dataclass
 from pathlib import Path
@@ -1638,7 +1639,7 @@ def test_tags_rules_get_version_tags(capsys: pytest.CaptureFixture):
 
 def test_changelog_file_name_from_args_and_config():
     mock_config = Mock(spec=BaseConfig)
-    mock_config.path.parent = "/my/project/"
+    mock_config.path.parent = "/my/project"
     mock_config.settings = {
         "name": "cz_conventional_commits",
         "changelog_file": "CHANGELOG.md",
@@ -1658,8 +1659,12 @@ def test_changelog_file_name_from_args_and_config():
         "unreleased_version": "1.0.1",
     }
     changelog = Changelog(mock_config, args)
-    assert changelog.file_name == "/my/project/CUSTOM.md"
+    assert os.path.normpath(changelog.file_name) == os.path.normpath(
+        os.path.join("/my/project", "CUSTOM.md")
+    )
 
     args = {"incremental": None, "dry_run": False, "unreleased_version": "1.0.1"}
     changelog = Changelog(mock_config, args)
-    assert changelog.file_name == "/my/project/CHANGELOG.md"
+    assert os.path.normpath(changelog.file_name) == os.path.normpath(
+        os.path.join("/my/project", "CHANGELOG.md")
+    )

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`from __future__ import annotations`
`2`	`2`
	`3`	`+import os`
`3`	`4`	`import os.path`
`4`	`5`	`from difflib import SequenceMatcher`
`5`	`6`	`from operator import itemgetter`
`@@ -42,7 +43,7 @@ def __init__(self, config: BaseConfig, args):`
`42`	`43`	f"or the setting `changelog_file` in {self.config.path}"
`43`	`44`	`)`
`44`	`45`	`self.file_name = (`
`45`		`- str(Path(self.config.path.parent) / changelog_file_name)`
	`46`	`+ os.path.join(str(self.config.path.parent), changelog_file_name)`
`46`	`47`	`if self.config.path is not None`
`47`	`48`	`else changelog_file_name`
`48`	`49`	`)`