bug symfony#43591 [Config] Fix files sorting in GlobResource (lyrixx)

fabpot · fabpot · commit 4218aa361feb · 2021-10-19T17:28:52.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Config] Fix files sorting in GlobResource | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | It should be on path and not on info and it's a big perf boost: https://blackfire.io/profiles/compare/27f409a5-73c7-4285-9b58-e631abbdb325/graph ![image](https://user-images.githubusercontent.com/408368/137939653-6ad3cbc6-f61e-400b-ad72-212eb76c6e36.png) Commits ------- 2d2fe15 [Config] Fix files sorting in GlobResource
diff --git a/src/Symfony/Component/Config/Resource/GlobResource.php b/src/Symfony/Component/Config/Resource/GlobResource.php
@@ -123,7 +123,7 @@ public function getIterator()
         }
 
         if (null !== $paths) {
-            sort($paths);
+            natsort($paths);
             foreach ($paths as $path) {
                 if ($this->excludedPrefixes) {
                     $normalizedPath = str_replace('\\', '/', $path);
@@ -156,7 +156,7 @@ function (\SplFileInfo $file, $path) {
                     ),
                     \RecursiveIteratorIterator::LEAVES_ONLY
                 ));
-                uasort($files, 'strnatcmp');
+                uksort($files, 'strnatcmp');
 
                 foreach ($files as $path => $info) {
                     if ($info->isFile()) {
