fix: reduce gunicorn concurrency to at most 4 * maximum available cor… (GoogleCloudPlatform#259)

garethgeorge · web-flow · commit 2e04cc28ae02 · 2023-07-10T16:30:27.000-07:00
diff --git a/src/functions_framework/_http/gunicorn.py b/src/functions_framework/_http/gunicorn.py
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import os
+
 import gunicorn.app.base
 
 
@@ -20,7 +22,7 @@ def __init__(self, app, host, port, debug, **options):
         self.options = {
             "bind": "%s:%s" % (host, port),
             "workers": 1,
-            "threads": 1024,
+            "threads": (os.cpu_count() or 1) * 4,
             "timeout": 0,
             "loglevel": "error",
             "limit_request_line": 0,
diff --git a/tests/test_http.py b/tests/test_http.py
@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import os
 import platform
 import sys
 
@@ -97,15 +98,15 @@ def test_gunicorn_application(debug):
     assert gunicorn_app.options == {
         "bind": "%s:%s" % (host, port),
         "workers": 1,
-        "threads": 1024,
+        "threads": os.cpu_count() * 4,
         "timeout": 0,
         "loglevel": "error",
         "limit_request_line": 0,
     }
 
     assert gunicorn_app.cfg.bind == ["1.2.3.4:1234"]
     assert gunicorn_app.cfg.workers == 1
-    assert gunicorn_app.cfg.threads == 1024
+    assert gunicorn_app.cfg.threads == os.cpu_count() * 4
     assert gunicorn_app.cfg.timeout == 0
     assert gunicorn_app.load() == app
 
