Detect API error responses as XML, see jublo#1

mynetx · mynetx · commit 7e6ca03bb7f5 · 2013-04-11T18:47:30.000+02:00
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,6 +1,9 @@
 codebird-php - changelog
 ========================
 
+2.3.3 (not yet released)
++ Detect API error responses as XML, see #1
+
 2.3.2 (2013-04-09)
 + Use protected keyword for methods that may be overriden in extended classes
 
diff --git a/src/codebird.php b/src/codebird.php
@@ -864,13 +864,24 @@ protected function _parseApiReply($method, $reply)
             }
         } elseif (!$parsed = json_decode($reply, $need_array)) {
             if ($reply) {
-                $reply = explode('&', $reply);
-                foreach ($reply as $element) {
-                    if (stristr($element, '=')) {
-                        list($key, $value) = explode('=', $element);
-                        $parsed[$key] = $value;
-                    } else {
-                        $parsed['message'] = $element;
+                if (stripos($reply, '<' . '?xml version="1.0" encoding="UTF-8"?' . '>') === 0) {
+                    // we received XML...
+                    // since this only happens for errors,
+                    // don't perform a full decoding
+                    preg_match('/<request>(.*)<\/request>/', $reply, $request);
+                    preg_match('/<error>(.*)<\/error>/', $reply, $error);
+                    $parsed['request'] = htmlspecialchars_decode($request[1]);
+                    $parsed['error'] = htmlspecialchars_decode($error[1]);
+                } else {
+                    // assume query format
+                    $reply = explode('&', $reply);
+                    foreach ($reply as $element) {
+                        if (stristr($element, '=')) {
+                            list($key, $value) = explode('=', $element);
+                            $parsed[$key] = $value;
+                        } else {
+                            $parsed['message'] = $element;
+                        }
                     }
                 }
             }
