From 023437a27cacccefa0e3af960370f2968098f7ea Mon Sep 17 00:00:00 2001 From: Konstantin Nosov Date: Sat, 13 Jun 2020 14:27:48 +0300 Subject: [PATCH 1/5] problems with deploy on firebase in firebase environment app folder is readonly. Only `/tmp` is writable. To solve an issue in any env we need to ask tmp folder location from system, which is done it that PR. --- src/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index defff75..9525409 100644 --- a/src/index.js +++ b/src/index.js @@ -3,6 +3,8 @@ /* eslint-disable no-console */ /* eslint indent: "error" */ const fs = require('fs'); +const os = require('os'); +const path = require('path'); const { spawn } = require('child_process'); @@ -26,7 +28,7 @@ const checkDataTypeCompatibility = (params) => { module.exports = function openssl(params, callback = () => undefined) { const stdout = []; const stderr = []; - const dir = 'openssl/'; + const dir = os.tmpdir()+path.sep+'openssl'+path.sep; let parameters = params From ceb653ff85fc4c724d1cbe86acb8eb30c327cf5e Mon Sep 17 00:00:00 2001 From: Konstantin Nosov Date: Sat, 13 Jun 2020 15:54:06 +0300 Subject: [PATCH 2/5] use path.join istead of string concat --- src/index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/index.js b/src/index.js index 9525409..c04f6e0 100644 --- a/src/index.js +++ b/src/index.js @@ -28,7 +28,7 @@ const checkDataTypeCompatibility = (params) => { module.exports = function openssl(params, callback = () => undefined) { const stdout = []; const stderr = []; - const dir = os.tmpdir()+path.sep+'openssl'+path.sep; + const dir = path.join(os.tmpdir(), 'openssl'); let parameters = params @@ -56,7 +56,7 @@ module.exports = function openssl(params, callback = () => undefined) { fs.mkdirSync(dir); } - const filename = dir + parameters[i].name + const filename =path.join(dir, parameters[i].name) fs.writeFileSync(filename, parameters[i].buffer, (err) => { if (err) { @@ -65,11 +65,11 @@ module.exports = function openssl(params, callback = () => undefined) { }); parameters[i] = parameters[i].name - parameters[i] = dir + parameters[i]; + parameters[i] = path.join(dir, parameters[i]); } if (checkCommandForIO(parameters[i]) && typeof parameters[i + 1] !== 'object') { - parameters[i + 1] = dir + parameters[i + 1]; + parameters[i + 1] = path.join(dir, parameters[i + 1]); } } From 69cd6431cf19483883644e23c3f2ac8692a03a5c Mon Sep 17 00:00:00 2001 From: Konstantin Nosov Date: Sat, 13 Jun 2020 15:55:30 +0300 Subject: [PATCH 3/5] temporary debug info --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index c04f6e0..9b0076a 100644 --- a/src/index.js +++ b/src/index.js @@ -73,7 +73,7 @@ module.exports = function openssl(params, callback = () => undefined) { } } - + console.info(parameters); const openSSLProcess = spawn('openssl', parameters); openSSLProcess.stdout.on('data', (data) => { From cae88f993770ceec54df380ff4eba47f8ac8ecd8 Mon Sep 17 00:00:00 2001 From: Konstantin Nosov Date: Sat, 13 Jun 2020 16:01:42 +0300 Subject: [PATCH 4/5] change log verbosity level --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index 9b0076a..a5f6680 100644 --- a/src/index.js +++ b/src/index.js @@ -73,7 +73,7 @@ module.exports = function openssl(params, callback = () => undefined) { } } - console.info(parameters); + console.log('Opens SSL params:',parameters); const openSSLProcess = spawn('openssl', parameters); openSSLProcess.stdout.on('data', (data) => { From f0e23931b31e4c6fcf974d5a109d734c179a3fcf Mon Sep 17 00:00:00 2001 From: Konstantin Nosov Date: Sat, 13 Jun 2020 17:26:03 +0300 Subject: [PATCH 5/5] remove log output --- src/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/index.js b/src/index.js index a5f6680..edb23ee 100644 --- a/src/index.js +++ b/src/index.js @@ -73,7 +73,6 @@ module.exports = function openssl(params, callback = () => undefined) { } } - console.log('Opens SSL params:',parameters); const openSSLProcess = spawn('openssl', parameters); openSSLProcess.stdout.on('data', (data) => {