Don't compare a signed value with an unsigned one

nemequ · nemequ · commit 8e45dbf20089 · 2015-11-14T22:28:30.000-08:00
This triggers a warning on MSVC (C4018) at level 3, as well as GCC with
-Wsign-compare (enabled with -Wextra).
diff --git a/src/xpress_huff_compress.cpp b/src/xpress_huff_compress.cpp
@@ -90,7 +90,7 @@ static size_t xh_compress_lz77(const_bytes in, int32_t /* * */ in_len, const_byt
 			if (rem >= 3 && (len = d->Find(in, &off)) >= 3)
 			{
 				// TODO: allow len > rem (chunk-spanning matches)
-				if (len > rem) { len = rem; }
+				if (len > (uint32_t)rem) { len = rem; }
 				in += len; rem -= len;
 				
 				//d->Add(in + 1, len - 1);

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ static size_t xh_compress_lz77(const_bytes in, int32_t /* * */ in_len, const_byt`
`90`	`90`	`if (rem >= 3 && (len = d->Find(in, &off)) >= 3)`
`91`	`91`	`{`
`92`	`92`	`// TODO: allow len > rem (chunk-spanning matches)`
`93`		`- if (len > rem) { len = rem; }`
	`93`	`+ if (len > (uint32_t)rem) { len = rem; }`
94	`94`	`in += len; rem -= len;`
`95`	`95`
`96`	`96`	`//d->Add(in + 1, len - 1);`