8000 style: exempt `issue_number`, `pull_number`, `tag_name` and `release_… · coderbyheart/github@ba8d0fc · GitHub
[go: up one dir, main page]
Skip to content

Commit ba8d0fc

Browse files
gr2mpvdlg
gr2m
authored and
pvdlg
committed
style: exempt issue_number, pull_number, tag_name and release_id from camelcase rule
1 parent b2bc352 commit ba8d0fc

File tree

4 files changed

+7
-9
lines changed

4 files changed

+7
-9
lines changed

‎lib/add-channel.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ const resolveConfig = require('./resolve-config');
55
const getClient = require('./get-client');
66
const isPrerelease = require('./is-prerelease');
77

8-
/* eslint-disable camelcase */
9-
108
module.exports = async (pluginConfig, context) => {
119
const {
1210
options: {repositoryUrl},
@@ -62,5 +60,3 @@ module.exports = async (pluginConfig, context) => {
6260

6361
return {url, name: RELEASE_NAME};
6462
};
65-
66-
/* eslint-enable camelcase */

‎lib/fail.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ module.exports = async (pluginConfig, context) => {
3131

3232
if (srIssue) {
3333
logger.log('Found existing semantic-release issue #%d.', srIssue.number);
34-
// eslint-disable-next-line camelcase
3534
const comment = {owner, repo, issue_number: srIssue.number, body};
3635
debug('create comment: %O', comment);
3736
const {

‎lib/success.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,9 @@ module.exports = async (pluginConfig, context) => {
5050
const prs = await pFilter(
5151
uniqBy(flatten(await Promise.all(searchQueries)), 'number'),
5252
async ({number}) =>
53-
// eslint-disable-next-line camelcase
5453
(await github.pullRequests.listCommits({owner, repo, pull_number: number})).data.find(({sha}) =>
5554
shas.includes(sha)
56-
) || shas.includes((await github.pullRequests.get({owner, repo, pull_number: number})).data.merge_commit_sha) // eslint-disable-line camelcase
55+
) || shas.includes((await github.pullRequests.get({owner, repo, pull_number: number})).data.merge_commit_sha)
5756
);
5857

5958
debug('found pull requests: %O', prs.map(pr => pr.number));
@@ -120,7 +119,6 @@ module.exports = async (pluginConfig, context) => {
120119
srIssues.map(async issue => {
121120
debug('close issue: %O', issue);
122121
try {
123-
// eslint-disable-next-line camelcase
124122
const updateIssue = {owner, repo, issue_number: issue.number, state: 'closed'};
125123
debug('closing issue: %O', updateIssue);
126124
const {

‎package.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,11 @@
107107
},
108108
"xo": {
109109
"prettier": true,
110-
"space": true
110+
"space": true,
111+
"rules": {
112+
"camelcase": ["error", {
113+
"allow": ["issue_number", "pull_number", "tag_name", "release_id"]
114+
}]
115+
}
111116
}
112117
}

0 commit comments

Comments
 (0)
0