8000 fix: typos in fail messages (#205) · coderbyheart/github@7e66a99 · GitHub
[go: up one dir, main page]
Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 7e66a99

Browse files
Ithildirgr2m
Ithildir
authored and
gr2m
committed
fix: typos in fail messages (semantic-release#205)
1 parent 9ea29dd commit 7e66a99

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

‎README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
| `verifyConditions` | Verify the presence and the validity of the authentication (set via [environment variables](#environment-variables)) and the [assets](#assets) option configuration. |
1616
| `publish` | Publish a [GitHub release](https://help.github.com/articles/about-releases), optionally uploading file assets. |
1717
| `success` | Add a comment to each [GitHub Issue](https://help.github.com/articles/about-issues) or [Pull Request](https://help.github.com/articles/about-pull-requests) resolved by the release and close issues previously open by the `fail` step. |
18-
| `fail` | Open or update a [GitHub Issue](https://help.github.com/articles/about-issues) with informations about the errors that caused the release to fail. |
18+
| `fail` | Open or update a [GitHub Issue](https://help.github.com/articles/about-issues) with information about the errors that caused the release to fail. |
1919

2020
## Install
2121

@@ -158,7 +158,7 @@ The message for the issue content is generated with [Lodash template](https://lo
158158
| Parameter | Description |
159159
|-----------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
160160
| `branch` | The branch from which the release had failed. |
161-
| `errors` | An `Array` of [SemanticReleaseError](https://github.com/semantic-release/error). Each error has the `message`, `code`, `pluginName` and `details` properties.<br>`pluginName` contains the package name of the plugin that threw the error.<br>`details` contains a informations about the error formatted in markdown. |
161+
| `errors` | An `Array` of [SemanticReleaseError](https://github.com/semantic-release/error). Each error has the `message`, `code`, `pluginName` and `details` properties.<br>`pluginName` contains the package name of the plugin that threw the error.<br>`details` contains a information about the error formatted in markdown. |
162162

163163
##### failComment examples
164164

‎lib/get-fail-comment.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ const NEW_ISSUE_URL = `${HOME_URL}/issues/new`;
77
const formatError = error => `### ${error.message}
88
99
${error.details ||
10-
`Unfortunatly this error doesn't have any additionnal information.${
10+
`Unfortunately this error doesn't have any additional information.${
1111
error.pluginName
12-
? ` Feel free to kindly ask the author of the \`${error.pluginName}\` plugin to add more helpful informations.`
12+
? ` Feel free to kindly ask the author of the \`${error.pluginName}\` plugin to add more helpful information.`
1313
: ''
1414
}`}`;
1515

‎test/get-fail-comment.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ test('Comment with missing error details and pluginName', t => {
3434
t.regex(comment, /the `master` branch/);
3535
t.regex(
3636
comment,
37-
/---\n\n### Error message 1\n\nUnfortunatly this error doesn't have any additionnal information. Feel free to kindly ask the author of the `some-plugin` plugin to add more helpful informations.\n\n---/
37+
/---\n\n### Error message 1\n\nUnfortunately this error doesn't have any additional information. Feel free to kindly ask the author of the `some-plugin` plugin to add more helpful information.\n\n---/
3838
);
3939
});
4040

@@ -46,6 +46,6 @@ test('Comment with missing error details and no pluginName', t => {
4646
t.regex(comment, /the `master` branch/);
4747
t.regex(
4848
comment,
49-
/---\n\n### Error message 1\n\nUnfortunatly this error doesn't have any additionnal information.\n\n---/
49+
/---\n\n### Error message 1\n\nUnfortunately this error doesn't have any additional information.\n\n---/
5050
);
5151
});

0 commit comments

Comments
 (0)
0