8000 style: exempt "issue_number" and "pull_number" from camelcase rule · coderbyheart/github@6f92175 · GitHub
[go: up one dir, main page]

Skip to content

Commit 6f92175

Browse files
gr2mpvdlg
authored andcommitted
style: exempt "issue_number" and "pull_number" from camelcase rule
1 parent fa677fa commit 6f92175

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

lib/fail.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ module.exports = async (pluginConfig, context) => {
3030

3131
if (srIssue) {
3232
logger.log('Found existing semantic-release issue #%d.', srIssue.number);
33-
// eslint-disable-next-line camelcase
3433
const comment = {owner, repo, issue_number: srIssue.number, body};
3534
debug('create comment: %O', comment);
3635
const {

lib/success.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,9 @@ module.exports = async (pluginConfig, context) => {
5151
const prs = await pFilter(
5252
uniqBy(flatten(await Promise.all(searchQueries)), 'number'),
5353
async ({number}) =>
54-
// eslint-disable-next-line camelcase
5554
(await github.pullRequests.listCommits({owner, repo, pull_number: number})).data.find(({sha}) =>
5655
shas.includes(sha)
57-
) || shas.includes((await github.pullRequests.get({owner, repo, pull_number: number})).data.merge_commit_sha) // eslint-disable-line camelcase
56+
) || shas.includes((await github.pullRequests.get({owner, repo, pull_number: number})).data.merge_commit_sha)
5857
);
5958

6059
debug('found pull requests: %O', prs.map(pr => pr.number));
@@ -78,11 +77,9 @@ module.exports = async (pluginConfig, context) => {
7877
? template(successComment)({branch, lastRelease, commits, nextRelease, releases, issue})
7978
: getSuccessComment(issue, releaseInfos, nextRelease);
8079
try {
81-
// eslint-disable-next-line camelcase
8280
const state = issue.state || (await github.issues.get({owner, repo, issue_number: issue.number})).data.state;
8381

8482
if (state === 'closed') {
85-
// eslint-disable-next-line camelcase
8683
const comment = {owner, repo, issue_number: issue.number, body};
8784
debug('create comment: %O', comment);
8885
const {
@@ -128,7 +125,6 @@ module.exports = async (pluginConfig, context) => {
128125
srIssues.map(async issue => {
129126
debug('close issue: %O', issue);
130127
try {
131-
// eslint-disable-next-line camelcase
132128
const updateIssue = {owner, repo, issue_number: issue.number, state: 'closed'};
133129
debug('closing issue: %O', updateIssue);
134130
const {

package.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,11 @@
108108
},
109109
"xo": {
110110
"prettier": true,
111-
"space": true
111+
"space": true,
112+
"rules": {
113+
"camelcase": ["error", {
114+
"allow": ["issue_number", "pull_number"]
115+
}]
116+
}
112117
}
113118
}

0 commit comments

Comments
 (0)
0