chore(package): update xo to version 0.24.0

greenkeeper[bot] · pvdlg · commit 287c8a11b2fc · 2019-01-22T17:18:06.000-05:00
diff --git a/index.js b/index.js
@@ -31,6 +31,7 @@ async function publish(pluginConfig, context) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
   }
+
   return publishGitHub(pluginConfig, context);
 }
 
@@ -39,6 +40,7 @@ async function addChannel(pluginConfig, context) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
   }
+
   return addChannelGitHub(pluginConfig, context);
 }
 
@@ -47,6 +49,7 @@ async function success(pluginConfig, context) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
   }
+
   await successGitHub(pluginConfig, context);
 }
 
@@ -55,6 +58,7 @@ async function fail(pluginConfig, context) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
   }
+
   await failGitHub(pluginConfig, context);
 }
 
diff --git a/lib/add-channel.js b/lib/add-channel.js
@@ -45,6 +45,7 @@ module.exports = async (pluginConfig, context) => {
       logger.log('Published GitHub release: %s', url);
       return {url, name: RELEASE_NAME};
     }
+
     throw error;
   }
 
@@ -61,3 +62,5 @@ module.exports = async (pluginConfig, context) => {
 
   return {url, name: RELEASE_NAME};
 };
+
+/* eslint-enable camelcase */
diff --git a/lib/definitions/errors.js b/lib/definitions/errors.js
@@ -1,9 +1,8 @@
-const url = require('url');
 const {inspect} = require('util');
 const {isString} = require('lodash');
 const pkg = require('../../package.json');
 
-const homepage = url.format({...url.parse(pkg.homepage), ...{hash: null}});
+const [homepage] = pkg.homepage.split('#');
 const stringify = obj => (isString(obj) ? obj : inspect(obj, {breakLength: Infinity, depth: 2, maxArrayLength: 5}));
 const linkify = file => `${homepage}/blob/master/${file}`;
 
diff --git a/lib/get-client.js b/lib/get-client.js
@@ -1,4 +1,4 @@
-const url = require('url');
+const {URL} = require('url');
 const {memoize, get} = require('lodash');
 const Octokit = require('@octokit/rest');
 const pRetry = require('p-retry');
@@ -35,7 +35,7 @@ module.exports = ({githubToken, githubUrl, githubApiPathPrefix, proxy}) => {
     baseUrl,
     request: {
       agent: proxy
-        ? baseUrl && url.parse(baseUrl).protocol.replace(':', '') === 'http'
+        ? baseUrl && new URL(baseUrl).protocol.replace(':', '') === 'http'
           ? new HttpProxyAgent(proxy)
           : new HttpsProxyAgent(proxy)
         : undefined,
@@ -54,6 +54,7 @@ module.exports = ({githubToken, githubUrl, githubApiPathPrefix, proxy}) => {
         if (SKIP_RETRY_CODES.includes(error.status)) {
           throw new pRetry.AbortError(error);
         }
+
         throw error;
       }
     }, RETRY_CONF);
diff --git a/lib/get-search-queries.js b/lib/get-search-queries.js
@@ -7,6 +7,7 @@ module.exports = (base, commits, separator = '+') => {
     } else {
       searches.push(`${base}${separator}${commit}`);
     }
+
     return searches;
   }, []);
 };
diff --git a/lib/publish.js b/lib/publish.js
@@ -45,6 +45,7 @@ module.exports = async (pluginConfig, context) => {
           logger.error('The asset %s cannot be read, and will be ignored.', filePath);
           return;
         }
+
         if (!file || !file.isFile()) {
           logger.error('The asset %s is not a file, and will be ignored.', filePath);
           return;
diff --git a/package.json b/package.json
@@ -48,7 +48,7 @@
     "server-destroy": "^1.0.1",
     "sinon": "^7.1.1",
     "tempy": "^0.2.1",
-    "xo": "^0.23.0"
+    "xo": "^0.24.0"
   },
   "engines": {
     "node": ">=8.3"
diff --git a/test/get-client.test.js b/test/get-client.test.js
@@ -170,8 +170,6 @@ test('Use different throttler for read and write endpoints', async t => {
 
 test('Use the same throttler when retrying', async t => {
   const coreRate = 200;
-
-  // eslint-disable-next-line require-await
   const request = stub().callsFake(async () => {
     const err = new Error();
     err.time = Date.now();

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ async function publish(pluginConfig, context) {`
`31`	`31`	`await verifyGitHub(pluginConfig, context);`
`32`	`32`	`verified = true;`
`33`	`33`	`}`
	`34`	`+`
`34`	`35`	`return publishGitHub(pluginConfig, context);`
`35`	`36`	`}`
`36`	`37`
`@@ -39,6 +40,7 @@ async function addChannel(pluginConfig, context) {`
`39`	`40`	`await verifyGitHub(pluginConfig, context);`
`40`	`41`	`verified = true;`
`41`	`42`	`}`
	`43`	`+`
`42`	`44`	`return addChannelGitHub(pluginConfig, context);`
`43`	`45`	`}`
`44`	`46`
`@@ -47,6 +49,7 @@ async function success(pluginConfig, context) {`
`47`	`49`	`await verifyGitHub(pluginConfig, context);`
`48`	`50`	`verified = true;`
`49`	`51`	`}`
	`52`	`+`
`50`	`53`	`await successGitHub(pluginConfig, context);`
`51`	`54`	`}`
`52`	`55`
`@@ -55,6 +58,7 @@ async function fail(pluginConfig, context) {`
`55`	`58`	`await verifyGitHub(pluginConfig, context);`
`56`	`59`	`verified = true;`
`57`	`60`	`}`
	`61`	`+`
`58`	`62`	`await failGitHub(pluginConfig, context);`
`59`	`63`	`}`
`60`	`64`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ module.exports = async (pluginConfig, context) => {`
`45`	`45`	`logger.log('Published GitHub release: %s', url);`
`46`	`46`	`return {url, name: RELEASE_NAME};`
`47`	`47`	`}`
	`48`	`+`
`48`	`49`	`throw error;`
`49`	`50`	`}`
`50`	`51`
`@@ -61,3 +62,5 @@ module.exports = async (pluginConfig, context) => {`
`61`	`62`
`62`	`63`	`return {url, name: RELEASE_NAME};`
`63`	`64`	`};`
	`65`	`+`
	`66`	`+/* eslint-enable camelcase */`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ module.exports = (base, commits, separator = '+') => {`
`7`	`7`	`} else {`
`8`	`8`	searches.push(`${base}${separator}${commit}`);
`9`	`9`	`}`
	`10`	`+`
`10`	`11`	`return searches;`
`11`	`12`	`}, []);`
`12`	`13`	`};`