Do not extend AND/OR/NOT from BasePermission

kevin-brown · kevin-brown · commit e709378ddbf4 · 2019-11-13T22:06:47.000-05:00
This can be done in a separate pull request, but it was reverted out of this one because it made it more difficult to review and increased its chances of not being accepted.
diff --git a/rest_framework/permissions.py b/rest_framework/permissions.py
@@ -47,29 +47,7 @@ def __call__(self, *args, **kwargs):
         return self.operator_class(op1, op2)
 
 
-class BasePermissionMetaclass(OperationHolderMixin, type):
-    pass
-
-
-class BasePermission(metaclass=BasePermissionMetaclass):
-    """
-    A base class from which all permission classes should inherit.
-    """
-
-    def has_permission(self, request, view):
-        """
-        Return `True` if permission is granted, `False` otherwise.
-        """
-        return True
-
-    def has_object_permission(self, request, view, obj):
-        """
-        Return `True` if permission is granted, `False` otherwise.
-        """
-        return True
-
-
-class AND(BasePermission):
+class AND:
     def __init__(self, *args):
         self.permissions = args
 
@@ -86,7 +64,7 @@ def has_object_permission(self, request, view, obj):
         return True
 
 
-class OR(BasePermission):
+class OR:
     def __init__(self, *args):
         self.permissions = args
 
@@ -103,7 +81,7 @@ def has_object_permission(self, request, view, obj):
         return False
 
 
-class NOT(BasePermission):
+class NOT:
     def __init__(self, op1):
         self.op1 = op1
 
@@ -114,6 +92,28 @@ def has_object_permission(self, request, view, obj):
         return not self.op1.has_object_permission(request, view, obj)
 
 
+class BasePermissionMetaclass(OperationHolderMixin, type):
+    pass
+
+
+class BasePermission(metaclass=BasePermissionMetaclass):
+    """
+    A base class from which all permission classes should inherit.
+    """
+
+    def has_permission(self, request, view):
+        """
+        Return `True` if permission is granted, `False` otherwise.
+        """
+        return True
+
+    def has_object_permission(self, request, view, obj):
+        """
+        Return `True` if permission is granted, `False` otherwise.
+        """
+        return True
+
+
 class AllowAny(BasePermission):
     """
     Allow any access.
