fix(@angular/ssr): prevent stream draining if write does not return a boolean

alan-agius4 · alan-agius4 · commit ee8466de520c · 2025-03-11T15:24:54.000+01:00
Implements a workaround for CodeGenieApp/serverless-express#683 Closes angular#29801
diff --git a/packages/angular/ssr/node/src/response.ts b/packages/angular/ssr/node/src/response.ts
@@ -76,7 +76,9 @@ export async function writeResponseToNodeResponse(
       }
 
       const canContinue = (destination as ServerResponse).write(value);
-      if (!canContinue) {
+      if (canContinue === false) {
+        // Explicitly check for `false`, as AWS may return `undefined` even though this is not valid.
+        // See: https://github.com/CodeGenieApp/serverless-express/issues/683
         await new Promise<void>((resolve) => destination.once('drain', resolve));
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,9 @@ export async function writeResponseToNodeResponse(`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`const canContinue = (destination as ServerResponse).write(value);`
`79`		`- if (!canContinue) {`
	`79`	`+ if (canContinue === false) {`
	`80`	+ // Explicitly check for `false`, as AWS may return `undefined` even though this is not valid.
	`81`	`+ // See: https://github.com/CodeGenieApp/serverless-express/issues/683`
`80`	`82`	`await new Promise<void>((resolve) => destination.once('drain', resolve));`
`81`	`83`	`}`
`82`	`84`	`}`