8000 Should use path.Match instead of filepath.Match · Issue #451 · coder/websocket · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Should use path.Match instead of filepath.Match #451
Closed
@MagicalTux

Description

@MagicalTux

https://github.com/nhooyr/websocket/blob/v1.8.11/accept.go#L237

Typically, path/filepath is used for OS-specific paths/etc while path has a OS neutral Match() method that works exactly the same in most cases.

A network lib shouldn't be using methods which behavior might vary depending on the OS.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0