8000 README.md: Mention gorilla advantage re no extra context cancellation… · coder/websocket@8060f3a · GitHub
[go: up one dir, main page]
Skip to content

Commit 8060f3a

Browse files
nhooyrnhooyr
committed
README.md: Mention gorilla advantage re no extra context cancellation goroutine
Not sure how/when this was lost but an important disadvantage to note.
1 parent 454aee8 commit 8060f3a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

‎README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ Advantages of [gorilla/websocket](https://github.com/gorilla/websocket):
102102
- Mature and widely used
103103
- [Prepared writes](https://pkg.go.dev/github.com/gorilla/websocket#PreparedMessage)
104104
- Configurable [buffer sizes](https://pkg.go.dev/github.com/gorilla/websocket#hdr-Buffers)
105+
- No extra goroutine per connection to support cancellation with context.Context. This costs nhooyr.io/websocket 2 KB of memory per connection.
106+
- Will be removed soon with [context.AfterFunc](https://github.com/golang/go/issues/57928). See [#411](https://github.com/nhooyr/websocket/issues/411)
105107

106108
Advantages of nhooyr.io/websocket:
107109

0 commit comments

Comments
 (0)
0