8000 Fix Wasm test on CI · coder/websocket@6adbf0c · GitHub
[go: up one dir, main page]

Skip to content

Commit 6adbf0c

Browse files
committed
Fix Wasm test on CI
1 parent 43c4dc0 commit 6adbf0c

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

.travis.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,24 @@ jobs:
1111
include:
1212
- name: Format
1313
before_script:
14-
- sudo apt-get install -y npm
14+
- sudo apt-get update && sudo apt-get install -y npm
1515
- sudo npm install -g prettier
1616
- sudo curl -L "$SHFMT_URL" > /usr/local/bin/shfmt && sudo chmod +x /usr/local/bin/shfmt
1717
- go get golang.org/x/tools/cmd/stringer
1818
- go get golang.org/x/tools/cmd/goimports
1919
script: make -j16 fmt
2020
- name: Lint
2121
before_script:
22-
- sudo apt-get install -y shellcheck
22+
- sudo apt-get update && sudo apt-get install -y shellcheck
2323
- go get golang.org/x/lint/golint
2424
script: make -j16 lint
2525
- name: Test
2626
before_script:
27-
- sudo apt-get install -y chromium-browser
2827
- go get github.com/agnivade/wasmbrowsertest
2928
- go get github.com/mattn/goveralls
3029
script: make -j16 test
31-
32-
addons:
33-
apt:
34-
update: true
30+
addons:
31+
chrome: stable
3532

3633
cache:
3734
npm: true

conn_test.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,6 @@ func TestConn(t *testing.T) {
268268
func TestWasm(t *testing.T) {
269269
t.Parallel()
270270

271-
if os.Getenv("CI") != "" {
272-
t.Skip("skipping on CI")
273-
}
274-
275271
var wg sync.WaitGroup
276272
s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
277273
wg.Add(1)
@@ -301,12 +297,12 @@ func TestWasm(t *testing.T) {
301297
ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
302298
defer cancel()
303299

304-
cmd := exec.CommandContext(ctx, "go", "test", "-exec=wasmbrowsertest", "./...")
300+
cmd := exec.CommandContext(ctx, "go", "test", "-v", "-exec=wasmbrowsertest", "./...")
305301
cmd.Env = append(os.Environ(), "GOOS=js", "GOARCH=wasm", fmt.Sprintf("WS_ECHO_SERVER_URL=%v", wstest.URL(s)))
306302

307303
b, err := cmd.CombinedOutput()
308304
if err != nil {
309-
t.Fatalf("wasm test binary failed: %v:\n%s", err, b)
305+
t.Fatalf("wasm test binary failed %q: %v:\n%s", cmd.Args, err, b)
310306
}
311307
}
312308

0 commit comments

Comments
 (0)
0