From 88d8e75de8a53de6154703deb8876842dad932ff Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 15:34:13 +0000 Subject: [PATCH 1/9] ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 .github/workflows/nightly-flake.yaml diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml new file mode 100644 index 0000000000000..870461551e60b --- /dev/null +++ b/.github/workflows/nightly-flake.yaml @@ -0,0 +1,34 @@ +name: nightly-flake +description: A flake a day keeps the doctor away. +on: + schedule: + # Every day at midnight + - cron: "0 0 * * *" + workflow_dispatch: +steps: + test-go-race: + runs-on: 'buildjet-8vcpu-ubuntu-2204' + # This runner costs 0.016 USD per minute, + # so 0.016 * 240 = 3.84 USD per run. + timeout-minutes: 240 + steps: + - uses: actions/checkout@v3 + + - uses: ./.github/actions/setup-go + + - uses: hashicorp/setup-terraform@v2 + with: + terraform_version: 1.1.9 + terraform_wrapper: false + + - name: Run Tests + run: | + # -race is likeliest to catch flaky tests + # due to correctness detection and its performance + # impact. + gotestsum --junitfile="gotests.xml" -- -count=10 -race ./... + + - uses: ./.github/actions/upload-datadog + if: always() + with: + api-key: ${{ secrets.DATADOG_API_KEY }} From 6bb0258c0297f2b97ab5b7b2eb0d70c50f362d4b Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 15:35:27 +0000 Subject: [PATCH 2/9] fixup! ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 46 ++++++++++++++-------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml index 870461551e60b..fe8f52cd94e25 100644 --- a/.github/workflows/nightly-flake.yaml +++ b/.github/workflows/nightly-flake.yaml @@ -5,30 +5,30 @@ on: # Every day at midnight - cron: "0 0 * * *" workflow_dispatch: -steps: - test-go-race: - runs-on: 'buildjet-8vcpu-ubuntu-2204' - # This runner costs 0.016 USD per minute, - # so 0.016 * 240 = 3.84 USD per run. - timeout-minutes: 240 - steps: - - uses: actions/checkout@v3 +jobs: + test-go-race: + runs-on: 'buildjet-8vcpu-ubuntu-2204' + # This runner costs 0.016 USD per minute, + # so 0.016 * 240 = 3.84 USD per run. + timeout-minutes: 240 + steps: + - uses: actions/checkout@v3 - - uses: ./.github/actions/setup-go + - uses: ./.github/actions/setup-go - - uses: hashicorp/setup-terraform@v2 - with: - terraform_version: 1.1.9 - terraform_wrapper: false + - uses: hashicorp/setup-terraform@v2 + with: + terraform_version: 1.1.9 + terraform_wrapper: false - - name: Run Tests - run: | - # -race is likeliest to catch flaky tests - # due to correctness detection and its performance - # impact. - gotestsum --junitfile="gotests.xml" -- -count=10 -race ./... + - name: Run Tests + run: | + # -race is likeliest to catch flaky tests + # due to correctness detection and its performance + # impact. + gotestsum --junitfile="gotests.xml" -- -count=10 -race ./... - - uses: ./.github/actions/upload-datadog - if: always() - with: - api-key: ${{ secrets.DATADOG_API_KEY }} + - uses: ./.github/actions/upload-datadog + if: always() + with: + api-key: ${{ secrets.DATADOG_API_KEY }} From 8a6ba7236f4872157602da495b65b69583b50be9 Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 15:37:28 +0000 Subject: [PATCH 3/9] fixup! ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 44 ++++++++++++++-------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml index fe8f52cd94e25..ff00e834ee355 100644 --- a/.github/workflows/nightly-flake.yaml +++ b/.github/workflows/nightly-flake.yaml @@ -6,29 +6,29 @@ on: - cron: "0 0 * * *" workflow_dispatch: jobs: - test-go-race: - runs-on: 'buildjet-8vcpu-ubuntu-2204' - # This runner costs 0.016 USD per minute, - # so 0.016 * 240 = 3.84 USD per run. - timeout-minutes: 240 - steps: - - uses: actions/checkout@v3 + test-go-race: + runs-on: 'buildjet-8vcpu-ubuntu-2204' + # This runner costs 0.016 USD per minute, + # so 0.016 * 240 = 3.84 USD per run. + timeout-minutes: 240 + steps: + - uses: actions/checkout@v3 - - uses: ./.github/actions/setup-go + - uses: ./.github/actions/setup-go - - uses: hashicorp/setup-terraform@v2 - with: - terraform_version: 1.1.9 - terraform_wrapper: false + - uses: hashicorp/setup-terraform@v2 + with: + terraform_version: 1.1.9 + terraform_wrapper: false - - name: Run Tests - run: | - # -race is likeliest to catch flaky tests - # due to correctness detection and its performance - # impact. - gotestsum --junitfile="gotests.xml" -- -count=10 -race ./... + - name: Run Tests + run: | + # -race is likeliest to catch flaky tests + # due to correctness detection and its performance + # impact. + gotestsum --junitfile="gotests.xml" -- -count=10 -race ./... - - uses: ./.github/actions/upload-datadog - if: always() - with: - api-key: ${{ secrets.DATADOG_API_KEY }} + - uses: ./.github/actions/upload-datadog + if: always() + with: + api-key: ${{ secrets.DATADOG_API_KEY }} From 122dc075e7b91207f66949af7e056f4f6f2e4852 Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 15:47:16 +0000 Subject: [PATCH 4/9] fixup! ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml index ff00e834ee355..3160861a147d2 100644 --- a/.github/workflows/nightly-flake.yaml +++ b/.github/workflows/nightly-flake.yaml @@ -5,6 +5,10 @@ on: # Every day at midnight - cron: "0 0 * * *" workflow_dispatch: + push: + paths: + # For testing purposes + - ".github/workflows/nightly-flake.yaml" jobs: test-go-race: runs-on: 'buildjet-8vcpu-ubuntu-2204' From 721f52b8405e62866d8ec280ace7451e7b54b5bf Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 15:47:33 +0000 Subject: [PATCH 5/9] fixup! ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml index 3160861a147d2..34ad9f4cf9c0f 100644 --- a/.github/workflows/nightly-flake.yaml +++ b/.github/workflows/nightly-flake.yaml @@ -1,5 +1,4 @@ name: nightly-flake -description: A flake a day keeps the doctor away. on: schedule: # Every day at midnight From af96322d8e5f44a7dc08b65f12779ce540f61251 Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 15:53:12 +0000 Subject: [PATCH 6/9] fixup! ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml index 34ad9f4cf9c0f..6db6f17577138 100644 --- a/.github/workflows/nightly-flake.yaml +++ b/.github/workflows/nightly-flake.yaml @@ -10,6 +10,9 @@ on: - ".github/workflows/nightly-flake.yaml" jobs: test-go-race: + # While GitHub's toaster runners are likelier to flake, we want consistency + # between this environment and the regular test environment for DataDog + # statistics and to only show real workflow threats. runs-on: 'buildjet-8vcpu-ubuntu-2204' # This runner costs 0.016 USD per minute, # so 0.016 * 240 = 3.84 USD per run. From 3a6eae29f82f6ef4f31913e0c779d78d7611a39c Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 15:53:37 +0000 Subject: [PATCH 7/9] fixup! ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml index 6db6f17577138..4571ea69eab10 100644 --- a/.github/workflows/nightly-flake.yaml +++ b/.github/workflows/nightly-flake.yaml @@ -13,7 +13,7 @@ jobs: # While GitHub's toaster runners are likelier to flake, we want consistency # between this environment and the regular test environment for DataDog # statistics and to only show real workflow threats. - runs-on: 'buildjet-8vcpu-ubuntu-2204' + runs-on: "buildjet-8vcpu-ubuntu-2204" # This runner costs 0.016 USD per minute, # so 0.016 * 240 = 3.84 USD per run. timeout-minutes: 240 From 29c2653e7e77470b64747a18a49f46156b9e76a2 Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 16:19:30 +0000 Subject: [PATCH 8/9] fixup! ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml index 4571ea69eab10..9ecdc0f4ee4e5 100644 --- a/.github/workflows/nightly-flake.yaml +++ b/.github/workflows/nightly-flake.yaml @@ -32,7 +32,7 @@ jobs: # -race is likeliest to catch flaky tests # due to correctness detection and its performance # impact. - gotestsum --junitfile="gotests.xml" -- -count=10 -race ./... + gotestsum --junitfile="gotests.xml" -- -timeout=240m -count=10 -race ./... - uses: ./.github/actions/upload-datadog if: always() From 03a3bcd974462129ca1d4f3c101f6169683a95a9 Mon Sep 17 00:00:00 2001 From: Ammar Bandukwala Date: Fri, 2 Jun 2023 17:48:34 +0000 Subject: [PATCH 9/9] fixup! ci: add nightly flake workflow --- .github/workflows/nightly-flake.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-flake.yaml b/.github/workflows/nightly-flake.yaml index 9ecdc0f4ee4e5..35d361024439f 100644 --- a/.github/workflows/nightly-flake.yaml +++ b/.github/workflows/nightly-flake.yaml @@ -7,7 +7,7 @@ on: push: paths: # For testing purposes - - ".github/workflows/nightly-flake.yaml" + # - ".github/workflows/nightly-flake.yaml" jobs: test-go-race: # While GitHub's toaster runners are likelier to flake, we want consistency