From 90569fe3643e530fa1cc9e40260ccb657ff63deb Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Sun, 18 Dec 2022 21:09:52 +0000 Subject: [PATCH] fix: use static base date for timeline tests It was returning "yesterday" since today is Sunday ;p --- site/src/components/Timeline/Timeline.test.tsx | 4 ++-- site/src/components/Timeline/TimelineDateRow.tsx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/site/src/components/Timeline/Timeline.test.tsx b/site/src/components/Timeline/Timeline.test.tsx index c17cc356f8a17..d984f33ec15da 100644 --- a/site/src/components/Timeline/Timeline.test.tsx +++ b/site/src/components/Timeline/Timeline.test.tsx @@ -2,13 +2,13 @@ import { createDisplayDate } from "./TimelineDateRow" describe("createDisplayDate", () => { it("returns correctly for Saturdays", () => { - const now = new Date() + const now = new Date(2020, 1, 7) const date = new Date( now.getFullYear(), now.getMonth(), // Previous Saturday, from now. now.getDate() - now.getDay() - 1, ) - expect(createDisplayDate(date)).toEqual("last Saturday") + expect(createDisplayDate(date, now)).toEqual("last Saturday") }) }) diff --git a/site/src/components/Timeline/TimelineDateRow.tsx b/site/src/components/Timeline/TimelineDateRow.tsx index abeb1eb5f3c51..6419f537c66dd 100644 --- a/site/src/components/Timeline/TimelineDateRow.tsx +++ b/site/src/components/Timeline/TimelineDateRow.tsx @@ -10,8 +10,8 @@ export interface TimelineDateRow { // We only want the message related to the date since the time is displayed // inside of the build row -export const createDisplayDate = (date: Date): string => - formatRelative(date, new Date()).split(" at ")[0] +export const createDisplayDate = (date: Date, base = new Date()): string => + formatRelative(date, base).split(" at ")[0] export const TimelineDateRow: FC = ({ date }) => { const styles = useStyles()