From 521b129bf4db3eec8c13e4d150efdef67ac577d5 Mon Sep 17 00:00:00 2001 From: Jaayden Halko Date: Mon, 21 Apr 2025 16:47:10 +0000 Subject: [PATCH 1/4] chore: increase slider height --- site/src/components/Slider/Slider.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/components/Slider/Slider.tsx b/site/src/components/Slider/Slider.tsx index 4fdd21353e963..74a9aea827021 100644 --- a/site/src/components/Slider/Slider.tsx +++ b/site/src/components/Slider/Slider.tsx @@ -20,7 +20,7 @@ export const Slider = React.forwardRef< )} {...props} > - + Date: Mon, 21 Apr 2025 16:47:47 +0000 Subject: [PATCH 2/4] fix: adjust form width and slider value display --- .../DynamicParameter/DynamicParameter.tsx | 53 +++++++++++-------- .../CreateWorkspacePageViewExperimental.tsx | 2 +- 2 files changed, 31 insertions(+), 24 deletions(-) diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx index 68538488a2d05..25f3859b91029 100644 --- a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx +++ b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx @@ -57,12 +57,14 @@ export const DynamicParameter: FC = ({ data-testid={`parameter-field-${parameter.name}`} > - +
+ +
{parameter.diagnostics.length > 0 && ( )} @@ -132,11 +134,6 @@ const ParameterLabel: FC = ({ parameter, isPreset }) => { )} - {parameter.form_type === "slider" && ( - - {parameter.value.value} - - )} {hasDescription && ( @@ -296,18 +293,23 @@ const ParameterField: FC = ({ case "slider": return ( - onChange(value.toString())} - min={parameter.validations[0]?.validation_min ?? 0} - max={parameter.validations[0]?.validation_max ?? 100} - disabled={disabled} - /> +
+ onChange(value.toString())} + min={parameter.validations[0]?.validation_min ?? 0} + max={parameter.validations[0]?.validation_max ?? 100} + disabled={disabled} + /> + {parameter.value.value} +
); case "textarea": @@ -315,6 +317,11 @@ const ParameterField: FC = ({