From 74c154136f33b192b89346958739889923de604f Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Mon, 14 Apr 2025 15:15:12 +0400 Subject: [PATCH 1/2] chore: add logging for coderdtest server lifecycle --- coderd/coderdtest/coderdtest.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go index 0f0a99807a37d..a4028cb762b27 100644 --- a/coderd/coderdtest/coderdtest.go +++ b/coderd/coderdtest/coderdtest.go @@ -421,6 +421,7 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can handler.ServeHTTP(w, r) } })) + t.Logf("coderdtest server listening on %s", srv.Listener.Addr().String()) srv.Config.BaseContext = func(_ net.Listener) context.Context { return ctx } @@ -433,7 +434,12 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can } else { srv.Start() } - t.Cleanup(srv.Close) + t.Logf("coderdtest server started on %s", srv.URL) + t.Cleanup(func() { + t.Log("closing coderdtest server") + srv.Close() + t.Log("closed coderdtest server") + }) tcpAddr, ok := srv.Listener.Addr().(*net.TCPAddr) require.True(t, ok) From 810e91f6dfd5914759b33710c246fe4522855eb5 Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Mon, 14 Apr 2025 15:31:28 +0400 Subject: [PATCH 2/2] code review --- coderd/coderdtest/coderdtest.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go index a4028cb762b27..dbf1f62abfb28 100644 --- a/coderd/coderdtest/coderdtest.go +++ b/coderd/coderdtest/coderdtest.go @@ -436,9 +436,9 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can } t.Logf("coderdtest server started on %s", srv.URL) t.Cleanup(func() { - t.Log("closing coderdtest server") + t.Logf("closing coderdtest server on %s", srv.Listener.Addr().String()) srv.Close() - t.Log("closed coderdtest server") + t.Logf("closed coderdtest server on %s", srv.Listener.Addr().String()) }) tcpAddr, ok := srv.Listener.Addr().(*net.TCPAddr)