diff --git a/cli/support_test.go b/cli/support_test.go index 1fb336142d4be..e1ad7fca7b0a4 100644 --- a/cli/support_test.go +++ b/cli/support_test.go @@ -50,7 +50,8 @@ func TestSupportBundle(t *testing.T) { secretValue := uuid.NewString() seedSecretDeploymentOptions(t, &dc, secretValue) client, db := coderdtest.NewWithDatabase(t, &coderdtest.Options{ - DeploymentValues: dc.Values, + DeploymentValues: dc.Values, + HealthcheckTimeout: testutil.WaitSuperLong, }) owner := coderdtest.CreateFirstUser(t, client) r := dbfake.WorkspaceBuild(t, db, database.WorkspaceTable{ @@ -113,7 +114,8 @@ func TestSupportBundle(t *testing.T) { secretValue := uuid.NewString() seedSecretDeploymentOptions(t, &dc, secretValue) client := coderdtest.New(t, &coderdtest.Options{ - DeploymentValues: dc.Values, + DeploymentValues: dc.Values, + HealthcheckTimeout: testutil.WaitSuperLong, }) _ = coderdtest.CreateFirstUser(t, client) @@ -133,7 +135,8 @@ func TestSupportBundle(t *testing.T) { secretValue := uuid.NewString() seedSecretDeploymentOptions(t, &dc, secretValue) client, db := coderdtest.NewWithDatabase(t, &coderdtest.Options{ - DeploymentValues: dc.Values, + DeploymentValues: dc.Values, + HealthcheckTimeout: testutil.WaitSuperLong, }) admin := coderdtest.CreateFirstUser(t, client) r := dbfake.WorkspaceBuild(t, db, database.WorkspaceTable{ diff --git a/coderd/debug.go b/coderd/debug.go index 0ae62282a22d8..64c7c9e632d0a 100644 --- a/coderd/debug.go +++ b/coderd/debug.go @@ -84,13 +84,15 @@ func (api *API) debugDeploymentHealth(rw http.ResponseWriter, r *http.Request) { defer cancel() report := api.HealthcheckFunc(ctx, apiKey) - api.healthCheckCache.Store(report) + if report != nil { // Only store non-nil reports. + api.healthCheckCache.Store(report) + } return report, nil }) select { case <-ctx.Done(): - httpapi.Write(ctx, rw, http.StatusNotFound, codersdk.Response{ + httpapi.Write(ctx, rw, http.StatusServiceUnavailable, codersdk.Response{ Message: "Healthcheck is in progress and did not complete in time. Try again in a few seconds.", }) return diff --git a/coderd/debug_test.go b/coderd/debug_test.go index 0d5dfd1885f12..f7a0a180ec61d 100644 --- a/coderd/debug_test.go +++ b/coderd/debug_test.go @@ -117,7 +117,7 @@ func TestDebugHealth(t *testing.T) { require.NoError(t, err) defer res.Body.Close() _, _ = io.ReadAll(res.Body) - require.Equal(t, http.StatusNotFound, res.StatusCode) + require.Equal(t, http.StatusServiceUnavailable, res.StatusCode) }) t.Run("Refresh", func(t *testing.T) {