8000 Remove `onClick` from `BorderedMenu` · Issue #955 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content
Remove onClick from BorderedMenu #955
Closed
@code-asher

Description

@code-asher

I think all of the dropdown items as they exist in v1 could easily be NavLinks so I wonder if we should remove the ability to pass in an onClick and make path required. Maybe that would promote making sure nav items really are regular anchor-based nav items, too (in v1 trying to open "add organization" in a new tab by middle-mouse clicking for example does nothing because it utilizes onClick for page navigation instead of being a standard <a>). It would also prevent the issue we had where you had to hit the back button twice to go back from potentially reoccurring.

Metadata

Metadata

Assignees

Labels

siteArea: frontend dashboard

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0