8000 `--header` format changed in recent version, must be colon delimited now · Issue #8021 · coder/coder · GitHub
[go: up one dir, main page]

Skip to content
--header format changed in recent version, must be colon delimited now #8021
Closed
@JoshVee

Description

@JoshVee

43eee35 introduces https://github.com/gobwas/httphead for HTTP header parsing.

However, httphead uses colon-delimited key-value pairs, rather than =: https://github.com/gobwas/httphead/blob/935b70b38dcb69f249f00f338774bf75822c090a/head.go#L185

This is a breaking change and not reflected in the CLI options:

      --header string-array, $CODER_HEADER
          Additional HTTP headers added to all requests. Provide as key=value. Can be specified multiple times.

Earlier versions of the Coder CLI supported --header=key=value. Now it must be --header=key:value.

➜  coder login --header=foo=bar
invalid header: foo=bar
➜  coder login --header=foo:bar
Open the following in your browser:

        https://coder.foobar.com/cli-auth

> Paste your token here: 

Metadata

Metadata

Assignees

Labels

s0Major regression, all-hands-on-deck to fix

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0