8000 windows returns 1 on kill · coder/coder@ff24bcf · GitHub
[go: up one dir, main page]

Skip to content

Commit ff24bcf

Browse files
committed
windows returns 1 on kill
1 parent d0434e4 commit ff24bcf

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

agent/agentssh/agentssh_test.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,11 @@ func TestNewServer_Signal(t *testing.T) {
229229
err = sess.Wait()
230230
exitErr := &ssh.ExitError{}
231231
require.ErrorAs(t, err, &exitErr)
232-
require.Equal(t, 255, exitErr.ExitStatus())
232+
wantCode := 255
233+
if runtime.GOOS == "windows" {
234+
wantCode := 1
235+
}
236+
require.Equal(t, wantCode, exitErr.ExitStatus())
233237
})
234238
t.Run("PTY", func(t *testing.T) {
235239
t.Parallel()
@@ -304,7 +308,11 @@ func TestNewServer_Signal(t *testing.T) {
304308
err = sess.Wait()
305309
exitErr := &ssh.ExitError{}
306310
require.ErrorAs(t, err, &exitErr)
307-
require.Equal(t, 255, exitErr.ExitStatus())
311+
wantCode := 255
312+
if runtime.GOOS == "windows" {
313+
wantCode := 1
314+
}
315+
require.Equal(t, wantCode, exitErr.ExitStatus())
308316
})
309317
}
310318

0 commit comments

Comments
 (0)
0