8000 fix(site): center `/cli-auth` on firefox (#17929) · coder/coder@e5758a1 · GitHub
[go: up one dir, main page]

Skip to content

Commit e5758a1

Browse files
fix(site): center /cli-auth on firefox (#17929)
`-webkit-fill-available` is not available in Firefox: https://caniuse.com/mdn-css_properties_height_stretch `-moz-available` doesn't work on `height`, so we have to use `100vh`. Before: <img width="1405" alt="image" src="https://github.com/user-attachments/assets/bd0f4390-50e9-47fa-8501-f3e3483d3c0d" /> After: <img width="1329" alt="image" src="https://github.com/user-attachments/assets/f19f4b2a-3398-4d64-8e12-5cfcb84106a9" /> The existing CSS is retained in browsers that support `-webkit-fill-available`, i.e. chrome: <img width="253" alt="image" src="https://github.com/user-attachments/assets/c1b356b4-c228-4580-a4c3-cddc2e0327b4" />
1 parent dc21016 commit e5758a1

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

site/src/components/SignInLayout/SignInLayout.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ export const SignInLayout: FC<PropsWithChildren> = ({ children }) => {
1717
const styles = {
1818
container: {
1919
flex: 1,
20-
height: "-webkit-fill-available",
20+
// Fallback to 100vh
21+
height: ["100vh", "-webkit-fill-available"],
2122
display: "flex",
2223
justifyContent: "center",
2324
alignItems: "center",

site/src/pages/CliInstallPage/CliInstallPageView.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ export const CliInstallPageView: FC<CliInstallPageViewProps> = ({ origin }) => {
3939
const styles = {
4040
container: {
4141
flex: 1,
42-
height: "-webkit-fill-available",
42+
// Fallback to 100vh
43+
height: ["100vh", "-webkit-fill-available"],
4344
display: "flex",
4445
flexDirection: "column",
4546
justifyContent: "center",

0 commit comments

Comments
 (0)
0