coder
diff --git a/‎site/e2e/api.ts
Lines changed: 7 additions & 4 deletions b/‎site/e2e/api.ts
Lines changed: 7 additions & 4 deletions
diff --git a/‎site/e2e/tests/deployment/observability.spec.ts
Lines changed: 5 additions & 2 deletions b/‎site/e2e/tests/deployment/observability.spec.ts
Lines changed: 5 additions & 2 deletions
diff --git a/‎site/src/utils/time.ts
Lines changed: 1 addition & 0 deletions b/‎site/src/utils/time.ts
Lines changed: 1 addition & 0 deletions
@@ -8,6 +8,7 @@ import relativeTime from "dayjs/plugin/relativeTime";
 
 dayjs.extend(duration);
 dayjs.extend(relativeTime);
+import { humanDuration } from "utils/time";
 import { coderPort, defaultPassword } from "./constants";
 import { type LoginOptions, findSessionToken, randomName } from "./helpers";
 
@@ -295,13 +296,15 @@ export async function verifyConfigFlagDuration(
 	flag: string,
 ) {
 	const opt = findConfigOption(config, flag);
+	if (typeof opt.value !== "number") {
+		throw new Error(
+			`Option with env ${flag} should be a number, but got ${typeof opt.value}.`,
+		);
+	}
 	const configOption = page.locator(
 		`div.options-table .option-${flag} .option-value-string`,
 	);
-	//
-	await expect(configOption).toHaveText(
-		dayjs.duration((opt.value as number) / 1e6).humanize(),
-	);
+	await expect(configOption).toHaveText(humanDuration(opt.value / 1e6));
 }
 
 export function findConfigOption(
 
@@ -5,7 +5,6 @@ import {
 	verifyConfigFlagArray,
 	verifyConfigFlagBoolean,
 	verifyConfigFlagDuration,
-	verifyConfigFlagEmpty,
 	verifyConfigFlagString,
 } from "../../api";
 import { login } from "../../helpers";
@@ -28,7 +27,11 @@ test("enabled observability settings", async ({ page }) => {
 	await verifyConfigFlagBoolean(page, config, "enable-terraform-debug-mode");
 	await verifyConfigFlagBoolean(page, config, "enable-terraform-debug-mode");
 	await verifyConfigFlagDuration(page, config, "health-check-refresh");
-	await verifyConfigFlagEmpty(page, "health-check-threshold-database");
+	await verifyConfigFlagDuration(
+		page,
+		config,
+		"health-check-threshold-database",
+	);
 	await verifyConfigFlagString(page, config, "log-human");
 	await verifyConfigFlagString(page, config, "prometheus-address");
 	await verifyConfigFlagArray(
 
@@ -54,6 +54,7 @@ export function humanDuration(durationInMs: number) {
 		conjunction: " and ",
 		serialComma: false,
 		round: true,
+		units: ["y", "mo", "w", "d", "h", "m", "s", "ms"],
 	});
 }
Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ export function humanDuration(durationInMs: number) {`
`54`	`54`	`conjunction: " and ",`
`55`	`55`	`serialComma: false,`
`56`	`56`	`round: true,`
	`57`	`+ units: ["y", "mo", "w", "d", "h", "m", "s", "ms"],`
`57`	`58`	`});`
`58`	`59`	`}`
`59`	`60`