canEditOrganization was lying

code-asher · code-asher · commit 9f39257b9ef3 · 2024-08-06T15:58:22.000-08:00
diff --git a/site/src/api/queries/organizations.ts b/site/src/api/queries/organizations.ts
@@ -155,6 +155,13 @@ const orgChecks = (
     },
     action: "read",
   },
+  editGroups: {
+    object: {
+      resource_type: "group",
+      organization_id: organizationId,
+    },
+    action: "update",
+  },
   editOrganization: {
     object: {
       resource_type: "organization",
diff --git a/site/src/pages/ManagementSettingsPage/ManagementSettingsLayout.tsx b/site/src/pages/ManagementSettingsPage/ManagementSettingsLayout.tsx
@@ -30,8 +30,8 @@ export const canEditOrganization = (
   return (
     permissions &&
     (permissions.editOrganization ||
-      permissions.viewMembers ||
-      permissions.viewGroups)
+      permissions.editMembers ||
+      permissions.editGroups)
   );
 };
 
