chore: reduce Windows PG tests flakiness (#16090)

hugodutka · web-flow · commit 899836d47a73 · 2025-01-10T15:21:03.000+01:00
This PR:

- Reduces test parallelism on Windows in CI
- Unifies wait intervals on Windows with Linux and macOS. Previously we
had custom intervals for Windows to reduce test flakiness on smaller CI
workers, but we don't run tests on small CI workers anymore. Due to how
our CI file is defined, forks run tests on small CI machines, but I'm
not sure if the different intervals actually help or whether that's a
heuristic that happened to fix issues on a particular day and was it
ever reevaluated. I propose we make the change and if someone complains,
revert it.

In particular, reduced test parallelism seems to actually help: I was
able to run Windows tests 5 times in a row without flakes. Not sure if
that's going to fix the problem long term, but it seems worth trying.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -445,7 +445,10 @@ jobs:
             # C: drive is extremely slow: https://github.com/actions/runner-images/issues/8755
             mkdir -p "R:/temp/embedded-pg"
             go run scripts/embedded-pg/main.go -path "R:/temp/embedded-pg"
-            DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...
+            # Reduce test parallelism, mirroring what we do for race tests.
+            # We'd been encountering issues with timing related flakes, and
+            # this seems to help.
+            DB=ci gotestsum --format standard-quiet -- -v -short -count=1 -parallel 4 -p 4 ./...
           else
             go run scripts/embedded-pg/main.go
             DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...
diff --git a/testutil/duration.go b/testutil/duration.go
@@ -1,5 +1,3 @@
-//go:build !windows
-
 package testutil
 
 import (
diff --git a/testutil/duration_windows.go b/testutil/duration_windows.go

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-//go:build !windows`
`2`		`-`
`3`	`1`	`package testutil`
`4`	`2`
`5`	`3`	`import (`