fix(cli): calculate coder ping max correctly (#18734)

ethanndickson · web-flow · commit 7500aa4d6c4a · 2025-07-03T13:22:54.000+10:00
Embarassing mistake I made months ago 😦 

*Doesn't effect schmoder, since we don't parse that max, it calculates it itself
diff --git a/cli/ping.go b/cli/ping.go
@@ -53,7 +53,7 @@ func (s *pingSummary) addResult(r *ipnstate.PingResult) {
 	if s.Min == nil || r.LatencySeconds < s.Min.Seconds() {
 		s.Min = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second)))
 	}
-	if s.Max == nil || r.LatencySeconds > s.Min.Seconds() {
+	if s.Max == nil || r.LatencySeconds > s.Max.Seconds() {
 		s.Max = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second)))
 	}
 	s.latencySum += r.LatencySeconds
diff --git a/cli/ping_internal_test.go b/cli/ping_internal_test.go
@@ -21,11 +21,11 @@ func TestBuildSummary(t *testing.T) {
 			},
 			{
 				Err:            "",
-				LatencySeconds: 0.2,
+				LatencySeconds: 0.3,
 			},
 			{
 				Err:            "",
-				LatencySeconds: 0.3,
+				LatencySeconds: 0.2,
 			},
 			{
 				Err:            "ping error",

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func (s pingSummary) addResult(r ipnstate.PingResult) {`
`53`	`53`	`if s.Min == nil \|\| r.LatencySeconds < s.Min.Seconds() {`
`54`	`54`	`s.Min = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second)))`
`55`	`55`	`}`
`56`		`- if s.Max == nil \|\| r.LatencySeconds > s.Min.Seconds() {`
	`56`	`+ if s.Max == nil \|\| r.LatencySeconds > s.Max.Seconds() {`
`57`	`57`	`s.Max = ptr.Ref(time.Duration(r.LatencySeconds * float64(time.Second)))`
`58`	`58`	`}`
`59`	`59`	`s.latencySum += r.LatencySeconds`
Original file line number	Diff line number	Diff line change
`@@ -21,11 +21,11 @@ func TestBuildSummary(t *testing.T) {`
`21`	`21`	`},`
`22`	`22`	`{`
`23`	`23`	`Err: "",`
`24`		`- LatencySeconds: 0.2,`
	`24`	`+ LatencySeconds: 0.3,`
`25`	`25`	`},`
`26`	`26`	`{`
`27`	`27`	`Err: "",`
`28`		`- LatencySeconds: 0.3,`
	`28`	`+ LatencySeconds: 0.2,`
`29`	`29`	`},`
`30`	`30`	`{`
`31`	`31`	`Err: "ping error",`