8000 Uncomment and fix unit test · coder/coder@71e94e3 · GitHub
[go: up one dir, main page]

Skip to content
Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 71e94e3

Browse files
committed
Uncomment and fix unit test
1 parent 8a075f4 commit 71e94e3

File tree

1 file changed

+44
-44
lines changed

1 file changed

+44
-44
lines changed

cli/create_test.go

Lines changed: 44 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -252,48 +252,48 @@ func TestCreate(t *testing.T) {
252252
}
253253
<-doneChan
254254
})
255-
// t.Run("WithParameterFileNotContainingTheValue", func(t *testing.T) {
256-
// t.Parallel()
257-
// client := coderdtest.New(t, nil)
258-
// user := coderdtest.CreateFirstUser(t, client)
259-
// coderdtest.NewProvisionerDaemon(t, client)
260-
// version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, &echo.Responses{
261-
// Parse: []*proto.Parse_Response{{
262-
// Type: &proto.Parse_Response_Complete{
263-
// Complete: &proto.Parse_Complete{
264-
// ParameterSchemas: []*proto.ParameterSchema{{
265-
// AllowOverrideSource: true,
266-
// Name: "region",
267-
// Description: "description",
268-
// DefaultSource: &proto.ParameterSource{
269-
// Scheme: proto.ParameterSource_DATA,
270-
// Value: "something",
271-
// },
272-
// DefaultDestination: &proto.ParameterDestination{
273-
// Scheme: proto.ParameterDestination_PROVISIONER_VARIABLE,
274-
// },
275-
// }},
276-
// },
277-
// },
278-
// }},
279-
// Provision: echo.ProvisionComplete,
280-
// ProvisionDryRun: echo.ProvisionComplete,
281-
// })
282-
// coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
283-
// template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
284-
// parameterFile, _ := os.CreateTemp(t.TempDir(), "testParameterFile*.yaml")
285-
// _, _ = parameterFile.WriteString("zone: \"bananas\"")
286-
// cmd, root := clitest.New(t, "create", "my-workspace", "--template", template.Name, "--parameter-file", parameterFile.Name())
287-
// clitest.SetupConfig(t, client, root)
288-
// doneChan := make(chan struct{})
289-
// pty := ptytest.New(t)
290-
// cmd.SetIn(pty.Input())
291-
// cmd.SetOut(pty.Output())
292-
// go func() {
293-
// defer close(doneChan)
294-
// err := cmd.Execute()
295-
// require.EqualError(t, err, "Parameter value absent in parameter file for \"region\"!")
296-
// }()
297-
// <-doneChan
298-
// })
255+
t.Run("WithParameterFileNotContainingTheValue", func(t *testing.T) {
256+
t.Parallel()
257+
client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerD: true})
258+
user := coderdtest.CreateFirstUser(t, client)
259+
260+
version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, &echo.Responses{
261+
Parse: []*proto.Parse_Response{{
262+
Type: &proto.Parse_Response_Complete{
263+
Complete: &proto.Parse_Complete{
264+
ParameterSchemas: []*proto.ParameterSchema{{
265+
AllowOverrideSource: true,
266+
Name: "region",
267+
Description: "description",
268+
DefaultSource: &proto.ParameterSource{
269+
Scheme: proto.ParameterSource_DATA,
270+
Value: "something",
271+
},
272+
DefaultDestination: &proto.ParameterDestination{
273+
Scheme: proto.ParameterDestination_PROVISIONER_VARIABLE,
274+
},
275+
}},
276+
},
277+
},
278+
}},
279+
Provision: echo.ProvisionComplete,
280+
ProvisionDryRun: echo.ProvisionComplete,
281+
})
282+
coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
283+
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
284+
parameterFile, _ := os.CreateTemp(t.TempDir(), "testParameterFile*.yaml")
285+
_, _ = parameterFile.WriteString("zone: \"bananas\"")
286+
cmd, root := clitest.New(t, "create", "my-workspace", "--template", template.Name, "--parameter-file", parameterFile.Name())
287+
clitest.SetupConfig(t, client, root)
288+
doneChan := make(chan struct{})
289+
pty := ptytest.New(t)
290+
cmd.SetIn(pty.Input())
291+
cmd.SetOut(pty.Output())
292+
go func() {
293+
defer close(doneChan)
294+
err := cmd.Execute()
295+
require.EqualError(t, err, "Parameter value absent in parameter file for \"region\"!")
296+
}()
297+
<-doneChan
298+
})
299299
}

0 commit comments

Comments
 (0)
0