added logging to long lived connection opening functions

ibetitsmike · ibetitsmike · commit 66e2c3ec6d42 · 2025-04-07T09:45:46.000Z
diff --git a/coderd/inboxnotifications.go b/coderd/inboxnotifications.go
@@ -219,6 +219,9 @@ func (api *API) watchInboxNotifications(rw http.ResponseWriter, r *http.Request)
 	encoder := wsjson.NewEncoder[codersdk.GetInboxNotificationResponse](conn, websocket.MessageText)
 	defer encoder.Close(websocket.StatusNormalClosure)
 
+	// log the initial connection
+	httpmw.FromContext(ctx).WriteLog(ctx, http.StatusAccepted)
+
 	for {
 		select {
 		case <-ctx.Done():
diff --git a/coderd/provisionerjobs.go b/coderd/provisionerjobs.go
@@ -554,9 +554,8 @@ func (f *logFollower) follow() {
 		return
 	}
 
-	// write the initial connection to the logs
-	httpmw.FromContext(f.ctx).WriteLog(
-		f.ctx, http.StatusAccepted)
+	// log the initial connection
+	httpmw.FromContext(f.ctx).WriteLog(f.ctx, http.StatusAccepted)
 
 	// no need to wait if the job is done
 	if f.complete {
diff --git a/coderd/workspaceagents.go b/coderd/workspaceagents.go
@@ -555,6 +555,9 @@ func (api *API) workspaceAgentLogs(rw http.ResponseWriter, r *http.Request) {
 	t := time.NewTicker(recheckInterval)
 	defer t.Stop()
 
+	// log the initial connection
+	httpmw.FromContext(ctx).WriteLog(ctx, http.StatusAccepted)
+
 	go func() {
 		defer func() {
 			logger.Debug(ctx, "end log streaming loop")
@@ -928,6 +931,9 @@ func (api *API) derpMapUpdates(rw http.ResponseWriter, r *http.Request) {
 	encoder := wsjson.NewEncoder[*tailcfg.DERPMap](ws, websocket.MessageBinary)
 	defer encoder.Close(websocket.StatusGoingAway)
 
+	// log the initial connection
+	httpmw.FromContext(ctx).WriteLog(ctx, http.StatusAccepted)
+
 	go func(ctx context.Context) {
 		// TODO(mafredri): Is this too frequent? Use separate ping disconnect timeout?
 		t := time.NewTicker(api.AgentConnectionUpdateFrequency)
@@ -1315,6 +1321,9 @@ func (api *API) watchWorkspaceAgentMetadata(
 	sendTicker := time.NewTicker(sendInterval)
 	defer sendTicker.Stop()
 
+	// log the initial connection
+	httpmw.FromContext(ctx).WriteLog(ctx, http.StatusAccepted)
+
 	// Send initial metadata.
 	sendMetadata()
 
