fix: Invert err nil check for opening Git URL (#5077)

kylecarbs · web-flow · commit 50b5becfb09e · 2022-11-14T20:10:23.000-06:00
Thanks @kconley-sq! 🥳
diff --git a/cli/gitaskpass.go b/cli/gitaskpass.go
@@ -51,7 +51,7 @@ func gitAskpass() *cobra.Command {
 				return xerrors.Errorf("get git token: %w", err)
 			}
 			if token.URL != "" {
-				if err := openURL(cmd, token.URL); err != nil {
+				if err := openURL(cmd, token.URL); err == nil {
 					cmd.Printf("Your browser has been opened to authenticate with Git:\n\n\t%s\n\n", token.URL)
 				} else {
 					cmd.Printf("Open the following URL to authenticate with Git:\n\n\t%s\n\n", token.URL)

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ func gitAskpass() *cobra.Command {`
`51`	`51`	`return xerrors.Errorf("get git token: %w", err)`
`52`	`52`	`}`
`53`	`53`	`if token.URL != "" {`
`54`		`- if err := openURL(cmd, token.URL); err != nil {`
	`54`	`+ if err < 49C6 span class="pl-c1">:= openURL(cmd, token.URL); err == nil {`
`55`	`55`	`cmd.Printf("Your browser has been opened to authenticate with Git:\n\n\t%s\n\n", token.URL)`
`56`	`56`	`} else {`
`57`	`57`	`cmd.Printf("Open the following URL to authenticate with Git:\n\n\t%s\n\n", token.URL)`