8000 dont use interface · coder/coder@2cb35aa · GitHub
[go: up one dir, main page]

Skip to content

Commit 2cb35aa

Browse files
committed
dont use interface
1 parent 4f401e1 commit 2cb35aa

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

coderd/coderd.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"github.com/go-chi/chi/v5"
1313
"github.com/go-chi/chi/v5/middleware"
1414
"github.com/pion/webrtc/v3"
15-
"go.opentelemetry.io/otel/trace"
1615
"golang.org/x/xerrors"
1716
"google.golang.org/api/idtoken"
1817

@@ -29,6 +28,7 @@ import (
2928
"github.com/coder/coder/codersdk"
3029
"github.com/coder/coder/provisionerd/proto"
3130
"github.com/coder/coder/site"
31+
sdktrace "go.opentelemetry.io/otel/sdk/trace"
3232
)
3333

3434
// Options are requires parameters for Coder to start.
@@ -52,7 +52,7 @@ type Options struct {
5252
SSHKeygenAlgorithm gitsshkey.Algorithm
5353
TURNServer *turnconn.Server
5454
Authorizer rbac.Authorizer
55-
TracerProvider trace.TracerProvider
55+
TracerProvider *sdktrace.TracerProvider
5656
}
5757

5858
type CoderD interface {

coderd/tracing/httpmw.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import (
66

77
"github.com/go-chi/chi/middleware"
88
"github.com/go-chi/chi/v5"
9+
sdktrace "go.opentelemetry.io/otel/sdk/trace"
910
semconv "go.opentelemetry.io/otel/semconv/v1.10.0"
10-
"go.opentelemetry.io/otel/trace"
1111
)
1212

1313
// HTTPMW adds tracing to http routes.
14-
func HTTPMW(tracerProvider trace.TracerProvider, name string) func(http.Handler) http.Handler {
14+
func HTTPMW(tracerProvider *sdktrace.TracerProvider, name string) func(http.Handler) http.Handler {
1515
return func(next http.Handler) http.Handler {
1616
return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
1717
if tracerProvider == nil {

0 commit comments

Comments
 (0)
0