ci: Lock PostgreSQL database creation

kylecarbs · kylecarbs · commit 28cee52a3abd · 2022-01-30T01:52:57.000Z
There have been race conditions when multiple instances
are created at once. This is an attempt to fix!
diff --git a/database/postgres/postgres.go b/database/postgres/postgres.go
@@ -5,15 +5,26 @@ import (
 	"fmt"
 	"io/ioutil"
 	"os"
+	"sync"
 	"time"
 
 	"github.com/ory/dockertest/v3"
 	"github.com/ory/dockertest/v3/docker"
 	"golang.org/x/xerrors"
 )
 
+// Locks the creation of a PostgreSQL instance to one-at-a-time.
+// We experienced race conditions when creating multiple instances
+// at a time. Somehow they were sharing data...
+//
+// This may be an upstream issue with "dockertest".
+var createMutex sync.Mutex
+
 // Open creates a new PostgreSQL server using a Docker container.
 func Open() (string, func(), error) {
+	createMutex.Lock()
+	defer createMutex.Unlock()
+
 	pool, err := dockertest.NewPool("")
 	if err != nil {
 		return "", nil, xerrors.Errorf("create pool: %w", err)
@@ -50,6 +61,7 @@ func Open() (string, func(), error) {
 		return "", nil, xerrors.Errorf("could not start resource: %w", err)
 	}
 	hostAndPort := resource.GetHostPort("5432/tcp")
+	fmt.Printf("HOST AND PORT %s\n", hostAndPort)
 	dbURL := fmt.Sprintf("postgres://postgres:postgres@%s/postgres?sslmode=disable", hostAndPort)
 
 	// Docker should hard-kill the container after 120 seconds.
