refactor: extract dialog message to Language

BrunoQuaresma · BrunoQuaresma · commit 286fde650b81 · 2022-05-04T15:11:09.000Z
diff --git a/site/src/pages/UsersPage/UsersPage.test.tsx b/site/src/pages/UsersPage/UsersPage.test.tsx
@@ -24,7 +24,7 @@ const suspendUser = async (setupActionSpies: () => void) => {
 
   // Check if the confirm message is displayed
   const confirmDialog = screen.getByRole("dialog")
-  expect(confirmDialog).toHaveTextContent("Do you want to suspend the user TestUser?")
+  expect(confirmDialog).toHaveTextContent(`${UsersPageLanguage.suspendDialogMessagePrefix} ${MockUser.username}?`)
 
   // Setup spies to check the actions after
   setupActionSpies()
diff --git a/site/src/pages/UsersPage/UsersPage.tsx b/site/src/pages/UsersPage/UsersPage.tsx
@@ -9,6 +9,7 @@ import { UsersPageView } from "./UsersPageView"
 export const Language = {
   suspendDialogTitle: "Suspend user",
   suspendDialogAction: "Suspend",
+  suspendDialogMessagePrefix: "Do you want to suspend the user",
 }
 
 export const UsersPage: React.FC = () => {
@@ -56,7 +57,7 @@ export const UsersPage: React.FC = () => {
           }}
           description={
             <>
-              Do you want to suspend the user <strong>{userToBeSuspended?.username}</strong>?
+              {Language.suspendDialogMessagePrefix} <strong>{userToBeSuspended?.username}</strong>?
             </>
           }
         />
