simplify

mafredri · mafredri · commit 17ddb8e622d6 · 2025-02-24T13:59:50.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -752,6 +752,8 @@ func (a *agent) reportConnectionsLoop(ctx context.Context, aAPI proto.DRPCAgentC
 				break
 			}
 			payload := a.reportConnections[0]
+			// Release lock while we send the payload, this is safe
+			// since we only append to the slice.
 			a.reportConnectionsMu.Unlock()
 
 			logger := a.logger.With(slog.F("payload", payload))
@@ -763,14 +765,10 @@ func (a *agent) reportConnectionsLoop(ctx context.Context, aAPI proto.DRPCAgentC
 
 			logger.Debug(ctx, "successfully reported connection")
 
+			// Remove the payload we sent.
 			a.reportConnectionsMu.Lock()
 			a.reportConnections = a.reportConnections[1:]
-			count := len(a.reportConnections)
 			a.reportConnectionsMu.Unlock()
-
-			if count == 0 {
-				break
-			}
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -752,6 +752,8 @@ func (a *agent) reportConnectionsLoop(ctx context.Context, aAPI proto.DRPCAgentC`
`752`	`752`	`break`
`753`	`753`	`}`
`754`	`754`	`payload := a.reportConnections[0]`
	`755`	`+ // Release lock while we send the payload, this is safe`
	`756`	`+ // since we only append to the slice.`
`755`	`757`	`a.reportConnectionsMu.Unlock()`
`756`	`758`
`757`	`759`	`logger := a.logger.With(slog.F("payload", payload))`
`@@ -763,14 +765,10 @@ func (a *agent) reportConnectionsLoop(ctx context.Context, aAPI proto.DRPCAgentC`
`763`	`765`
`764`	`766`	`logger.Debug(ctx, "successfully reported connection")`
`765`	`767`
	`768`	`+ // Remove the payload we sent.`
`766`	`769`	`a.reportConnectionsMu.Lock()`
`767`	`770`	`a.reportConnections = a.reportConnections[1:]`
`768`		`- count := len(a.reportConnections)`
`769`	`771`	`a.reportConnectionsMu.Unlock()`
`770`		`-`
`771`		`- if count == 0 {`
`772`		`- break`
`773`		`- }`
`774`	`772`	`}`
`775`	`773`	`}`
`776`	`774`	`}`