linting

Emyrk · Emyrk · commit 0f1526373f1b · 2025-02-19T11:58:52.000-06:00
diff --git a/coderd/rbac/roles_test.go b/coderd/rbac/roles_test.go
@@ -555,15 +555,6 @@ func TestRolePermissions(t *testing.T) {
 				false: {setOtherOrg, memberMe, userAdmin, orgTemplateAdmin, orgUserAdmin, orgAuditor},
 			},
 		},
-		{
-			Name:     "ProvisionerKeys",
-			Actions:  []policy.Action{policy.ActionCreate, policy.ActionRead, policy.ActionDelete},
-			Resource: rbac.ResourceProvisionerKeys.InOrg(orgID),
-			AuthorizeMap: map[bool][]hasAuthSubjects{
-				true:  {owner, orgAdmin},
-				false: {setOtherOrg, memberMe, orgMemberMe, userAdmin, templateAdmin, orgTemplateAdmin, orgUserAdmin, orgAuditor},
-			},
-		},
 		{
 			Name:     "ProvisionerJobs",
 			Actions:  []policy.Action{policy.ActionRead},
diff --git a/enterprise/coderd/roles.go b/enterprise/coderd/roles.go
@@ -255,16 +255,15 @@ func filterInvalidPermissions(permissions []codersdk.Permission) []codersdk.Perm
 	// Filter out any invalid permissions
 	var validPermissions []codersdk.Permission
 	for _, permission := range permissions {
-		err := (&rbac.Permission{
+		err := rbac.Permission{
 			Negate:       permission.Negate,
 			ResourceType: string(permission.ResourceType),
 			Action:       policy.Action(permission.Action),
-		}).Valid()
-		if err == nil {
-			validPermissions = append(validPermissions, permission)
-		} else {
-			fmt.Println(err.Error())
+		}.Valid()
+		if err != nil {
+			continue
 		}
+		validPermissions = append(validPermissions, permission)
 	}
 	return validPermissions
 }
