Patch MainReader and Tabular

A. Apesteguia · A. Apesteguia · commit f405b34c4d05 · 2020-11-25T17:17:53.000+01:00
diff --git a/src/main/java/com/codepressed/CSVtoXML/Main.java b/src/main/java/com/codepressed/CSVtoXML/Main.java
@@ -9,8 +9,8 @@
 public class Main {
     /**
      * Executes the CSV to XML conversion
-     * @param args file input and output
-     *
+     * @author Daniel Apesteguia Timoner
+     * @param args Input file, output file and elements names.
      */
     public static void main(String[] args){
         //Arg validator
@@ -24,14 +24,21 @@ public static void main(String[] args){
         //Vars Initialization
         String csvFile = args[0];
         String xmlFile = args[1];
-        String elementName = args[2];
+        String elementName;
+        try{
+        elementName = args[2];}
+        catch (ArrayIndexOutOfBoundsException e){
+            System.out.println("You didn't especify any element so we will fix 'element' as parental node.");
+            elementName = "element";
+            }
+
 
         //ArrayList of ArrayStrings Generation with CSV
-        ArrayList<String[]> elements = null;
+        ArrayList<String[]> elements;
             elements = new Reader().CSVtoArrayList(csvFile);
 
         //XML Doc Generation with ArrayList
-        Document xmlDoc = null;
+        Document xmlDoc;
             xmlDoc = new TabularToXMLConverter().docBuilder(elements,elementName);
             TabularToXMLConverter.transformDocToFile(xmlDoc,xmlFile);
 
@@ -40,7 +47,7 @@ public static void main(String[] args){
         System.out.println("File wasn't found, error: "+e);
         }
         catch (TransformerException e){
-            System.out.println("Transformer error: "+e);;
+            System.out.println("Transformer error: "+e);
         }
         catch (ParserConfigurationException e) {
             System.out.println("Configuration error: "+e);
diff --git a/src/main/java/com/codepressed/CSVtoXML/Reader.java b/src/main/java/com/codepressed/CSVtoXML/Reader.java
@@ -10,8 +10,8 @@ public class Reader {
     public ArrayList<String[]> CSVtoArrayList(String csvFile) throws IOException {
         ArrayList<String[]> elements = new ArrayList<String[]>();
         String csvSplit = ",(?=([^\"]*\"[^\"]*\")*[^\"]*$)";
-        String line = "";
         BufferedReader csvReader = null;
+        String line;
 
         try {
             csvReader = new BufferedReader(new FileReader(csvFile));
diff --git a/src/main/java/com/codepressed/CSVtoXML/TabularToXMLConverter.java b/src/main/java/com/codepressed/CSVtoXML/TabularToXMLConverter.java
@@ -19,13 +19,15 @@ public class TabularToXMLConverter {
 
     //DOC Generation -> XML with ArrayList String elements
     public Document docBuilder(ArrayList<String[]> XMLelements, String elementName) throws ParserConfigurationException {
+        if (elementName == null){
+            elementName = "element";
+        }
         DocumentBuilderFactory xmlFactory = DocumentBuilderFactory.newInstance();
         DocumentBuilder xmlBuilder = xmlFactory.newDocumentBuilder();
         Document xmlDoc = xmlBuilder.newDocument();
 
         Element rootElement = xmlDoc.createElement("root");
         xmlDoc.appendChild(rootElement);
-
         Element mainElement = xmlDoc.createElement(elementName+"s");
         rootElement.appendChild(mainElement);
 
