Changed type_assert diagnostics to fall under reportGeneralTypeIssues diagnostic rule rather than be emitted unconditionally.

msfterictraut · msfterictraut · commit 4784a9ed88dc · 2022-06-29T21:33:51.000-07:00
diff --git a/packages/pyright-internal/src/analyzer/typeEvaluator.ts b/packages/pyright-internal/src/analyzer/typeEvaluator.ts
@@ -6950,7 +6950,9 @@ export function createTypeEvaluator(importLookup: ImportLookup, evaluatorOptions
         const assertedType = convertToInstance(getTypeOfArgumentExpectingType(node.arguments[1]).type);
 
         if (!isTypeSame(assertedType, arg0TypeResult.type)) {
-            addError(
+            addDiagnostic(
+                AnalyzerNodeInfo.getFileInfo(node).diagnosticRuleSet.reportGeneralTypeIssues,
+                DiagnosticRule.reportGeneralTypeIssues,
                 Localizer.Diagnostic.assertTypeTypeMismatch().format({
                     expected: printType(assertedType),
                     received: printType(arg0TypeResult.type),
