Move redirect to xml value

jingming · jingming · commit d28056c53cd1 · 2017-04-03T11:20:32.000-07:00
diff --git a/tests/unit/twiml/test_messaging_response.py b/tests/unit/twiml/test_messaging_response.py
@@ -19,15 +19,15 @@ def test_response(self):
 
         assert_equal(
             self.strip(r),
-            '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect url="example.com" /></Response>'
+            '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect>example.com</Redirect></Response>'
         )
 
     def test_response_chain(self):
         r = MessagingResponse().message('Hello').redirect(url='example.com')
 
         assert_equal(
             self.strip(r),
-            '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect url="example.com" /></Response>'
+            '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect>example.com</Redirect></Response>'
         )
 
 
@@ -74,5 +74,5 @@ def test_redirect(self):
 
         assert_equal(
             self.strip(r),
-            '<?xml version="1.0" encoding="UTF-8"?><Response><Redirect url="example.com" /></Response>'
+            '<?xml version="1.0" encoding="UTF-8"?><Response><Redirect>example.com</Redirect></Response>'
         )
diff --git a/twilio/twiml/messaging_response.py b/twilio/twiml/messaging_response.py
@@ -42,12 +42,12 @@ def message(self,
             **kwargs
         ))
 
-    def redirect(self, method=None, url=None, **kwargs):
+    def redirect(self, url, method=None, **kwargs):
         """
         Add a <Redirect> element
 
-        :param method: HTTP method
         :param url: URL to redirect to
+        :param method: HTTP method
         :param kwargs: other attributes
         :return: <Redirect> element
         """
@@ -124,5 +124,12 @@ class Redirect(TwiML):
     """
     <Redirect> element
     """
-    pass
+    def __init__(self, url, **kwargs):
+        """
+        Create a new <Redirect> element
+
+        :param url: redirect URL location
+        """
+        super(Redirect, self).__init__(**kwargs)
+        self.value = url
 

Original file line number	Diff line number	Diff line change
`@@ -19,15 +19,15 @@ def test_response(self):`
`19`	`19`
`20`	`20`	`assert_equal(`
`21`	`21`	`self.strip(r),`
`22`		`- '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect url="example.com" /></Response>'`
	`22`	`+ '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect>example.com</Redirect></Response>'`
`23`	`23`	`)`
`24`	`24`
`25`	`25`	`def test_response_chain(self):`
`26`	`26`	`r = MessagingResponse().message('Hello').redirect(url='example.com')`
`27`	`27`
`28`	`28`	`assert_equal(`
`29`	`29`	`self.strip(r),`
`30`		`- '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect url="example.com" /></Response>'`
	`30`	`+ '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect>example.com</Redirect></Response>'`
`31`	`31`	`)`
`32`	`32`
`33`	`33`
`@@ -74,5 +74,5 @@ def test_redirect(self):`
`74`	`74`
`75`	`75`	`assert_equal(`
`76`	`76`	`self.strip(r),`
`77`		`- '<?xml version="1.0" encoding="UTF-8"?><Response><Redirect url="example.com" /></Response>'`
	`77`	`+ '<?xml version="1.0" encoding="UTF-8"?><Response><Redirect>example.com</Redirect></Response>'`
`78`	`78`	`)`