Fixed bug that resulted in a false positive error when the second argument to a type constructor call includes a tuple that includes a type class.

msfterictraut · msfterictraut · commit be6003ae0617 · 2022-08-12T17:48:25.000-07:00
diff --git a/packages/pyright-internal/src/analyzer/typeEvaluator.ts b/packages/pyright-internal/src/analyzer/typeEvaluator.ts
@@ -10890,7 +10890,12 @@ export function createTypeEvaluator(importLookup: ImportLookup, evaluatorOptions
         );
         arg1Type.tupleTypeArguments.forEach((typeArg) => {
             const specializedType = makeTopLevelTypeVarsConcrete(typeArg.type);
-            if (isInstantiableClass(specializedType) || isAnyOrUnknown(specializedType)) {
+
+            if (
+                isInstantiableClass(specializedType) ||
+                isAnyOrUnknown(specializedType) ||
+                (isClassInstance(specializedType) && ClassType.isBuiltIn(specializedType, 'type'))
+            ) {
                 classType.details.baseClasses.push(specializedType);
             } else {
                 addExpectedClassDiagnostic(typeArg.type, argList[1].valueExpression || errorNode);
diff --git a/packages/pyright-internal/src/tests/samples/newType2.py b/packages/pyright-internal/src/tests/samples/newType2.py
@@ -23,3 +23,7 @@ class B(X2, A):
 
 # This should generate an error because the second arg is not a tuple of class types.
 X5 = type("X5", (3,))
+
+
+X6 = type("", tuple({str}), {})
+X7 = type("", (float, str), {})
