Fixed bug that caused error to be suppressed when calling assert_never with bad arguments (incorrect number, etc).

msfterictraut · msfterictraut · commit 22c667f61a72 · 2022-08-08T13:25:36.000-07:00
diff --git a/packages/pyright-internal/src/analyzer/binder.ts b/packages/pyright-internal/src/analyzer/binder.ts
@@ -3119,8 +3119,6 @@ export class Binder extends ParseTreeWalker {
             this._currentFlowNode = flowNode;
         }
 
-        AnalyzerNodeInfo.setFlowNode(node, this._currentFlowNode!);
-
         if (!this._isCodeUnreachable()) {
             this._addExceptTargets(this._currentFlowNode!);
         }
diff --git a/packages/pyright-internal/src/tests/samples/never2.py b/packages/pyright-internal/src/tests/samples/never2.py
@@ -37,6 +37,11 @@ def func2(val: str | int) -> str:
         assert_never2(val)
 
 
+def func3():
+    # This should generate an error because of the missing argument.
+    assert_never1()
+
+
 reveal_type(assert_never1, expected_text="(val: Never) -> NoReturn")
 
 # This should generate an error.
diff --git a/packages/pyright-internal/src/tests/typeEvaluator3.test.ts b/packages/pyright-internal/src/tests/typeEvaluator3.test.ts
@@ -764,7 +764,7 @@ test('Never1', () => {
 test('Never2', () => {
     const analysisResults = TestUtils.typeAnalyzeSampleFiles(['never2.py']);
 
-    TestUtils.validateResults(analysisResults, 3);
+    TestUtils.validateResults(analysisResults, 4);
 });
 
 test('TypePromotions1', () => {

Original file line number	Diff line number	Diff line change
`@@ -3119,8 +3119,6 @@ export class Binder extends ParseTreeWalker {`
`3119`	`3119`	`this._currentFlowNode = flowNode;`
`3120`	`3120`	`}`
`3121`	`3121`
`3122`		`- AnalyzerNodeInfo.setFlowNode(node, this._currentFlowNode!);`
`3123`		`-`
`3124`	`3122`	`if (!this._isCodeUnreachable()) {`
`3125`	`3123`	`this._addExceptTargets(this._currentFlowNode!);`
`3126`	`3124`	`}`