[FE-48] only admin see license info PART2 (arangodb#17916)

hkernbach · web-flow · commit c2f33e89b9c0 · 2023-01-11T14:58:09.000Z
* in addition to the original PR arangodb#15776 , we also must disable error notifications for the actual licence call itself - if parameter: --server.harden true is being set * added changelog entry
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,6 +1,11 @@
 devel
 -----
 
+* Web UI [FE-48]: Additional fix to the previously introduced license
+  information usability improvement. In case the server is being started with
+  the additional parameter `--server.harden`, the previous fix did not handle
+  that specific edge case.
+
 * Use more compact and efficient representation for arrays and objects during
   AQL AST serialization and deserialization. This can help to reduce the size
   of messages exchanged between coordinator and database servers during query
diff --git a/js/apps/system/_admin/aardvark/APP/frontend/js/views/navigationView.js b/js/apps/system/_admin/aardvark/APP/frontend/js/views/navigationView.js
@@ -142,10 +142,9 @@
           } else {
             self.showLicenseError();
           }
-        },
-        error: function () {
-          self.showLicenseError();
         }
+        // intentionally no error handling: non-root users may not be allowed to fetch license information, but in that case we do not want to show an error
+        // Additional note: This is required if "--server.harden true" is being set.
       });
     },
 

Original file line number	Diff line number	Diff line change
`@@ -142,10 +142,9 @@`
`142`	`142`	`} else {`
`143`	`143`	`self.showLicenseError();`
`144`	`144`	`}`
`145`		`- },`
`146`		`- error: function () {`
`147`		`- self.showLicenseError();`
`148`	`145`	`}`
	`146`	`+ // intentionally no error handling: non-root users may not be allowed to fetch license information, but in that case we do not want to show an error`
	`147`	`+ // Additional note: This is required if "--server.harden true" is being set.`
`149`	`148`	`});`
`150`	`149`	`},`
`151`	`150`