Force add a PR to the Merge Queue with failing required checks #8145
Replies: 4 comments 3 replies
-
|
Agreed. Would also be convenient to have a way to fast track PRs into the merge queue without waiting for them to finish building on the PR (so while the PR checks are 'yellow'). This workflow used to work without merge queue where any administrator could have the permission to bypass checks. Allowing bypassing checks when you have a merge queue based workflow works poorly, because then the PR is not even merged via the merge queue, which means the proper merge checks are also skipped. This essentially means that we now by having enabled merge queue on our repositories have lost one way to safely fast-track pull requests into production (by skipping essentially one of two check runs). I so far haven't been able to come up with any workaround that makes this practical in the current system. |
Beta Was this translation helpful? Give feedback.
-
|
I've now cooked up a scheme, where you apply a label with a specific magic string to your pull request. And then at the start of every github actions script, there's a check to see whether this label is applied on the PR. If the label is present, every check is written to early exit with a green status (or just the checks you want skippable). Note that they only check this when running in PR context. What you'll then need to do manually, is to after having applied your label on the PR, you need to re-run/re-start any checks that needs to be skipped. This does not solve the issue on bypassing number of required approved reviews, though. Just helps you by-pass very slow GitHub actions runs. A native solution to this problem is still very much needed, to make merge queue complete! |
Beta Was this translation helpful? Give feedback.
-
|
Here is an even worse case. I have no checks failing, but it's a global refactor affecting several apps in the monorepo, so I need an approve from the whole country. I have the admin privileges to bypass and merge this directly, but that would skip some conditional steps (like deploying internal docs) that only run during a merge queue event. your UX is annoying, github
|
Beta Was this translation helpful? Give feedback.
-
|
@mgaitan How did you fix it please? |
Beta Was this translation helpful? Give feedback.
-
|
we have a bot thats member of all the teams, so its only approve unblock everything. we instrumented it so if there is some conditions satisfied (example a label + the approve of a staff eng) a job trigger this bot to give the extra approve automatically |
Beta Was this translation helpful? Give feedback.
-
|
Ok |
Beta Was this translation helpful? Give feedback.
-
|
I came up with a similar solution to stianjensen, but without the need to modify every action: It works by adding a commit status named 'check-all-general-jobs-passed' to the PR commit. Our repository has 'check-all-general-jobs-passed' as our only required status (it's normally a job that has a 'needs' dependency on every other job). Adding a commit status also satisfies the required status branch protection check, so adding this label will allow an already-approved PR to immediately enter the merge queue. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Is it possible to add a PR to the Merge Queue forcefully even when there are still failing required checks? Sometimes even when a required check fails, we still want to enqueue a PR because the failure is deemed acceptable. Instead of admin merging the PR, we still want it to go through the Merge Queue because there are "fundamental checks" that run in the MQ and we want those to pass!
Today, we allow certain people to admin merge PRs but they skip the MQ, which can lead to compilation errors on the main branch.
Beta Was this translation helpful? Give feedback.
All reactions