Trace accounts for package manifest

skitterm · skitterm · commit 4e3a9b7c0f58 · 2022-10-31T16:38:57.000-07:00
diff --git a/bin-src/lib/getDependentStoryFiles.ts b/bin-src/lib/getDependentStoryFiles.ts
@@ -192,7 +192,7 @@ export async function getDependentStoryFiles(
     // If package.json dependencies changed, we still want to use the same TurboSnap bail reason
     // for now.
     // if package.jsons are untraced, don't bail, even when its dependency fields have changed
-  } else if (ctx.git.changedPackageManifests?.length && tracedFiles.filter(isPackageFile).length) {
+  } else if (ctx.git?.changedPackageManifests?.length && tracedFiles.filter(isPackageFile).length) {
     ctx.turboSnap.bailReason = { changedPackageFiles: ctx.git.changedPackageManifests };
   }
 
diff --git a/bin-src/trace.ts b/bin-src/trace.ts
@@ -2,6 +2,7 @@ import meow from 'meow';
 import { getDependentStoryFiles } from './lib/getDependentStoryFiles';
 import { Context } from './types';
 import { readStatsFile } from './tasks/read-stats-file';
+import { isPackageManifestFile } from './lib/utils';
 
 /**
  * Utility to trace a set of changed file paths to dependent story files using a Webpack stats file.
@@ -88,5 +89,12 @@ export async function main(argv: string[]) {
   const stats = await readStatsFile(flags.statsFile);
   const changedFiles = input.map((f) => f.replace(/^\.\//, ''));
 
+  const packageManifestFile = changedFiles.find((item) => isPackageManifestFile(item));
+  if (packageManifestFile) {
+    throw new Error(
+      'Unable to trace package manifest file as that would require diffing file contents.'
+    );
+  }
+
   await getDependentStoryFiles(ctx, stats, flags.statsFile, changedFiles);
 }

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ export async function getDependentStoryFiles(`
`192`	`192`	`// If package.json dependencies changed, we still want to use the same TurboSnap bail reason`
`193`	`193`	`// for now.`
`194`	`194`	`// if package.jsons are untraced, don't bail, even when its dependency fields have changed`
`195`		`- } else if (ctx.git.changedPackageManifests?.length && tracedFiles.filter(isPackageFile).length) {`
	`195`	`+ } else if (ctx.git?.changedPackageManifests?.length && tracedFiles.filter(isPackageFile).length) {`
`196`	`196`	`ctx.turboSnap.bailReason = { changedPackageFiles: ctx.git.changedPackageManifests };`
`197`	`197`	`}`
`198`	`198`