minor symfony#42371 [DependencyInjection] Remove unused code in DecoratorServicePass (lyrixx)

fabpot · fabpot · commit c9f821a1b630 · 2021-08-06T11:07:07.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Remove unused code in `DecoratorServicePass` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | this is also present on 4.4, but I'm not sure about the target branch according to the new merge policy Commits ------- a4f3dcc [DependencyInjection] Remove dead code in DecoratorServicePass
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php b/src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php
@@ -73,13 +73,11 @@ public function process(ContainerBuilder $container)
             if ($container->hasAlias($inner)) {
                 $alias = $container->getAlias($inner);
                 $public = $alias->isPublic();
-                $private = $alias->isPrivate();
                 $container->setAlias($renamedId, new Alias((string) $alias, false));
                 $decoratedDefinition = $container->findDefinition($alias);
             } elseif ($container->hasDefinition($inner)) {
                 $decoratedDefinition = $container->getDefinition($inner);
                 $public = $decoratedDefinition->isPublic();
-                $private = $decoratedDefinition->isPrivate();
                 $decoratedDefinition->setPublic(false);
                 $container->setDefinition($renamedId, $decoratedDefinition);
                 $decoratingDefinitions[$inner] = $decoratedDefinition;
@@ -88,7 +86,6 @@ public function process(ContainerBuilder $container)
                 continue;
             } elseif (ContainerInterface::NULL_ON_INVALID_REFERENCE === $invalidBehavior) {
                 $public = $definition->isPublic();
-                $private = $definition->isPrivate();
                 $decoratedDefinition = null;
             } else {
                 throw new ServiceNotFoundException($inner, $id);
