8000 fixes sigmavirus24/github3.py/issues/378 · christhompson/github3.py@c8e3588 · GitHub
[go: up one dir, main page]

Skip to content

Commit c8e3588

Browse files
frossiesigmavirus24
authored andcommitted
This fixes a failure of create_tag to create annotated tags as documented. The created reference should be the SHA of the created tag object, not the original tagged commit.
1 parent d132237 commit c8e3588

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

github3/repos/repo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -990,7 +990,7 @@ def create_tag(self, tag, message, sha, obj_type, tagger,
990990
url = self._build_url('git', 'tags', base_url=self._api)
991991
json = self._json(self._post(url, data=data), 201)
992992
if json:
993-
self.create_ref('refs/tags/' + tag, sha)
993+
self.create_ref('refs/tags/' + tag, json['sha'])
994994
return self._instance_or_null(Tag, json)
995995

996996
@requires_auth

0 commit comments

Comments
 (0)
0